Unit Test suites for AsyncTasks

[sanyud24]

Tested custom AsyncTask classes.

package org.opendatakit.services.resolve.task

CheckpointResolutionListTask

• Used Roboelectric ShadowEnvironment.setExternalStorageState(Environment.MEDIA_MOUNTED) to change the
  "card-status = mounted" and to set mock external storage.
• Mockito to mock ResolutionListener class

ConflictResolutionListTask

[odk-x-bot]

Can one of the admins verify this patch? Also need an authorization to run tests.

[sanyud24]

Hi @wbrunette @Lamouresparus , created the test for async task classes.

[wbrunette]

Your setup creates a background task each time. Does the task run? What happens if you cancel the task? What about making sure the task finishes?

[wbrunette]

This test does not seem to verify any behavior. Normally you see an assert to verify it's working

[sanyud24]

I had a doubt in this one, I actually wanted to test if resolutionListener will set to null after calling clearResolutionListener according to the class behavior, but I can't cause it can't be accessed. Can I add a getResolutionListener() to test the functionality of these two functions?

public ResolutionListener getResolutionListener() { return rl; }

[wbrunette]

This test does not seem to verify any behavior. Normally you see an assert to verify it's working

[sanyud24]

Your setup creates a background task each time. Does the task run? What happens if you cancel the task? What about making sure the task finishes?

Yeah, ur right!! added the asynctask.execute to make sure task runs and asynctask.cancel to make sure asynctask thread stops.

[sanyud24]

Hi @wbrunette, There's still the error of OdkConnectionFactorySingleton not initialized as it's a final class and mockito can't mock it. I'll look into the issue.

[wbrunette]

@sanyud24 did you solve the issue on of the mockito?

[sanyud24]

@sanyud24 did you solve the issue on of the mockito?

Yeah @wbrunette , I'm almost done with it.

[sanyud24]

Hi, @wbrunette fixed this PR and added a base test class.