Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18 - removes all deprecated methods #1760

Merged
merged 6 commits into from
Jun 11, 2020
Merged

v18 - removes all deprecated methods #1760

merged 6 commits into from
Jun 11, 2020

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 10, 2020

follow up to octokit/plugin-rest-endpoint-methods.js#135

Commit message body for squash & commit

BREAKING CHANGE: `Octokit.plugin()` no longer accepts an array as first argument. Pass multiple arguments instead, e.g. `Octokit.plugin(plugin1, plugin2)`

BREAKING CHANGE: deprecated `octokit.reactions.deleteLegacy()` has been removed

BREAKING CHANGE: deprecated `octokit.repos.getDownloads()` has been removed

BREAKING CHANGE: deprecated `octokit.repos.listDownloads()` has been removed

BREAKING CHANGE: deprecated `octokit.repos.deleteDownloads()` has been removed

BREAKING CHANGE: `octokit.actions.createOrUpdateRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.createOrUpdateSecretForRepo()` has been renamed to `octokit.actions.createOrUpdateRepoSecret()`

BREAKING CHANGE: `octokit.actions.createOrUpdateRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.createRegistrationToken()` has been renamed to `octokit.actions.createRegistrationTokenForRepo()`

BREAKING CHANGE: `octokit.actions.createRemoveToken()` has been renamed to `octokit.actions.createRemoveTokenForRepo()`

BREAKING CHANGE: `octokit.actions.deleteRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.deleteSecretFromRepo()` has been renamed to `octokit.actions.deleteRepoSecret()`

BREAKING CHANGE: `octokit.actions.deleteRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.downloadWorkflowJobLogs()` has been renamed to `octokit.actions.downloadJobLogsForWorkflowRun()`

BREAKING CHANGE: `octokit.actions.getPublicKey()` has been renamed to `octokit.actions.getRepoPublicKey()`

BREAKING CHANGE: `octokit.actions.getRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.getSecret()` has been renamed to `octokit.actions.getRepoSecret()`

BREAKING CHANGE: `octokit.actions.getRepoSecret()`: parameter `name` has been renamed to `secret_name`

BREAKING CHANGE: `octokit.actions.getSelfHostedRunner()` has been renamed to `octokit.actions.getSelfHostedRunnerForRepo()`

BREAKING CHANGE: `octokit.actions.getWorkflowJob()` has been renamed to `octokit.actions.getJobForWorkflowRun()`

BREAKING CHANGE: `octokit.actions.listDownloadsForSelfHostedRunnerApplication()` has been renamed to `octokit.actions.listRunnerApplicationsForRepo()`

BREAKING CHANGE: `octokit.actions.listRepoWorkflowRuns()` has been renamed to `octokit.actions.listWorkflowRunsForRepo()`

BREAKING CHANGE: `octokit.actions.listSecretsForRepo()` has been renamed to `octokit.actions.listRepoSecrets()`

BREAKING CHANGE: `octokit.actions.listWorkflowJobLogs()` has been renamed to `octokit.actions.downloadWorkflowJobLogs()`

BREAKING CHANGE: `octokit.actions.listWorkflowRunLogs()` has been renamed to `octokit.actions.downloadWorkflowRunLogs()`

BREAKING CHANGE: `octokit.actions.removeSelfHostedRunner()` has been renamed to `octokit.actions.deleteSelfHostedRunnerFromRepo()`

BREAKING CHANGE: `octokit.activity.checkStarringRepo()` has been renamed to `octokit.activity.checkRepoIsStarredByAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.getThreadSubscription()` has been renamed to `octokit.activity.getThreadSubscriptionForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.listEventsForOrg()` has been renamed to `octokit.activity.listOrgEventsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.listEventsForUser()` has been renamed to `octokit.activity.listEventsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.listFeeds()` has been renamed to `octokit.activity.getFeeds()`

BREAKING CHANGE: `octokit.activity.listNotifications()` has been renamed to `octokit.activity.listNotificationsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.listNotificationsForRepo()` has been renamed to `octokit.activity.listRepoNotificationsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.listPublicEventsForOrg()` has been renamed to `octokit.activity.listPublicOrgEvents()`

BREAKING CHANGE: `octokit.activity.markAsRead()` has been renamed to `octokit.activity.markNotificationsAsRead()`

BREAKING CHANGE: `octokit.activity.markNotificationsAsReadForRepo()` has been renamed to `octokit.activity.markRepoNotificationsAsRead()`

BREAKING CHANGE: `octokit.activity.starRepo()` has been renamed to `octokit.activity.starRepoForAuthenticatedUser()`

BREAKING CHANGE: `octokit.activity.unstarRepo()` has been renamed to `octokit.activity.unstarRepoForAuthenticatedUser()`

BREAKING CHANGE: `octokit.apps.checkAccountIsAssociatedWithAny()` has been renamed to `octokit.apps.getSubscriptionPlanForAccount()`

BREAKING CHANGE: `octokit.apps.checkAccountIsAssociatedWithAnyStubbed()` has been renamed to `octokit.apps.getSubscriptionPlanForAccountStubbed()`

BREAKING CHANGE: `octokit.apps.createInstallationToken()` has been renamed to `octokit.apps.createInstallationAccessToken()`

BREAKING CHANGE: `octokit.apps.listAccountsUserOrOrgOnPlan()` has been renamed to `octokit.apps.listAccountsForPlan()`

BREAKING CHANGE: `octokit.apps.listAccountsUserOrOrgOnPlanStubbed()` has been renamed to `octokit.apps.listAccountsForPlanStubbed()`

BREAKING CHANGE: `octokit.apps.listMarketplacePurchasesForAuthenticatedUser()` has been renamed to `octokit.apps.listSubscriptionsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.apps.listMarketplacePurchasesForAuthenticatedUserStubbed()` has been renamed to `octokit.apps.listSubscriptionsForAuthenticatedUserStubbed()`

BREAKING CHANGE: `octokit.apps.listRepos()` has been renamed to `octokit.apps.listReposAccessibleToInstallation()`

BREAKING CHANGE: `octokit.apps.revokeInstallationToken()` has been renamed to `octokit.apps.revokeInstallationAccessToken()`

BREAKING CHANGE: `octokit.codesOfConduct.listConductCodes()` has been renamed to `octokit.codesOfConduct.getAllCodesOfConduct()`

BREAKING CHANGE: `octokit.gists.listPublicForUser()` has been renamed to `octokit.gists.listForUser()`

BREAKING CHANGE: `octokit.gitignore.listTemplates()` has been renamed to `octokit.gitignore.getAllTemplates()`

BREAKING CHANGE: `octokit.interactions.addOrUpdateRestrictionsForOrg()` has been renamed to `octokit.interactions.setRestrictionsForOrg()`

BREAKING CHANGE: `octokit.interactions.addOrUpdateRestrictionsForRepo()` has been renamed to `octokit.interactions.setRestrictionsForRepo()`

BREAKING CHANGE: `octokit.issues.checkAssignee()` has been renamed to `octokit.issues.checkUserCanBeAssigned()`

BREAKING CHANGE: `octokit.issues.listMilestonesForRepo()` has been renamed to `octokit.issues.listMilestones()`

BREAKING CHANGE: `octokit.issues.removeLabels()` has been renamed to `octokit.issues.removeAllLabels()`

BREAKING CHANGE: `octokit.issues.replaceAllLabels()` has been renamed to `octokit.issues.setLabels()`

BREAKING CHANGE: `octokit.issues.replaceLabels()` has been renamed to `octokit.issues.replaceAllLabels()`

BREAKING CHANGE: `octokit.licenses.listCommonlyUsed()` has been renamed to `octokit.licenses.getAllCommonlyUsed()`

BREAKING CHANGE: `octokit.migrations.getImportProgress()` has been renamed to `octokit.migrations.getImportStatus()`

BREAKING CHANGE: `octokit.orgs.addOrUpdateMembership()` has been renamed to `octokit.orgs.setMembershipForUser()`

BREAKING CHANGE: `octokit.orgs.checkMembership()` has been renamed to `octokit.orgs.checkMembershipForUser()`

BREAKING CHANGE: `octokit.orgs.checkPublicMembership()` has been renamed to `octokit.orgs.checkPublicMembershipForUser()`

BREAKING CHANGE: `octokit.orgs.concealMembership()` has been renamed to `octokit.orgs.removePublicMembershipForAuthenticatedUser()`

BREAKING CHANGE: `octokit.orgs.createHook()` has been renamed to `octokit.orgs.createWebhook()`

BREAKING CHANGE: `octokit.orgs.deleteHook()` has been renamed to `octokit.orgs.deleteWebhook()`

BREAKING CHANGE: `octokit.orgs.getHook()` has been renamed to `octokit.orgs.getWebhook()`

BREAKING CHANGE: `octokit.orgs.getMembership()` has been renamed to `octokit.orgs.getMembershipForUser()`

BREAKING CHANGE: `octokit.orgs.listHooks()` has been renamed to `octokit.orgs.listWebhooks()`

BREAKING CHANGE: `octokit.orgs.listInstallations()` has been renamed to `octokit.orgs.listAppInstallations()`

BREAKING CHANGE: `octokit.orgs.listMemberships()` has been renamed to `octokit.orgs.listMembershipsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.orgs.pingHook()` has been renamed to `octokit.orgs.pingWebhook()`

BREAKING CHANGE: `octokit.orgs.publicizeMembership()` has been renamed to `octokit.orgs.setPublicMembershipForAuthenticatedUser()`

BREAKING CHANGE: `octokit.orgs.removeMembership()` has been renamed to `octokit.orgs.removeMembershipForUser()`

BREAKING CHANGE: `octokit.orgs.updateHook()` has been renamed to `octokit.orgs.updateWebhook()`

BREAKING CHANGE: `octokit.orgs.updateMembership()` has been renamed to `octokit.orgs.updateMembershipForAuthenticatedUser()`

BREAKING CHANGE: `octokit.projects.reviewUserPermissionLevel()` has been renamed to `octokit.projects.getPermissionForUser()`

BREAKING CHANGE: `octokit.pulls.createComment()` has been renamed to `octokit.pulls.createReviewComment()`

BREAKING CHANGE: `octokit.pulls.createReviewCommentReply()` has been renamed to `octokit.pulls.createReplyForReviewComment()`

BREAKING CHANGE: `octokit.pulls.createReviewRequest()` has been renamed to `octokit.pulls.requestReviewers()`

BREAKING CHANGE: `octokit.pulls.deleteComment()` has been renamed to `octokit.pulls.deleteReviewComment()`

BREAKING CHANGE: `octokit.pulls.deleteReviewRequest()` has been renamed to `octokit.pulls.removeRequestedReviewers()`

BREAKING CHANGE: `octokit.pulls.getComment()` has been renamed to `octokit.pulls.getReviewComment()`

BREAKING CHANGE: `octokit.pulls.getCommentsForReview()` has been renamed to `octokit.pulls.listCommentsForReview()`

BREAKING CHANGE: `octokit.pulls.listComments()` has been renamed to `octokit.pulls.listReviewComments()`

BREAKING CHANGE: `octokit.pulls.listCommentsForRepo()` has been renamed to `octokit.pulls.listReviewCommentsForRepo()`

BREAKING CHANGE: `octokit.pulls.listReviewRequests()` has been renamed to `octokit.pulls.listRequestedReviewers()`

BREAKING CHANGE: `octokit.pulls.updateComment()` has been renamed to `octokit.pulls.updateReviewComment()`

BREAKING CHANGE: `octokit.reactions.delete()` has been renamed to `octokit.reactions.deleteLegacy()`

BREAKING CHANGE: `octokit.repos.addDeployKey()` has been renamed to `octokit.repos.createDeployKey()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchAdminEnforcement()` has been renamed to `octokit.repos.setAdminBranchProtection()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchAppRestrictions()` has been renamed to `octokit.repos.addAppAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchRequiredSignatures()` has been renamed to `octokit.repos.createCommitSignatureProtection()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchRequiredStatusChecksContexts()` has been renamed to `octokit.repos.addStatusCheckContexts()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchTeamRestrictions()` has been renamed to `octokit.repos.addTeamAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.addProtectedBranchUserRestrictions()` has been renamed to `octokit.repos.addUserAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.createHook()` has been renamed to `octokit.repos.createWebhook()`

BREAKING CHANGE: `octokit.repos.createOrUpdateFile()` has been renamed to `octokit.repos.createOrUpdateFileContents()`

BREAKING CHANGE: `octokit.repos.createStatus()` has been renamed to `octokit.repos.createCommitStatus()`

BREAKING CHANGE: `octokit.repos.deleteHook()` has been renamed to `octokit.repos.deleteWebhook()`

BREAKING CHANGE: `octokit.repos.disablePagesSite()` has been renamed to `octokit.repos.deletePagesSite()`

BREAKING CHANGE: `octokit.repos.enablePagesSite()` has been renamed to `octokit.repos.createPagesSite()`

BREAKING CHANGE: `octokit.repos.getArchiveLink()` has been renamed to `octokit.repos.downloadArchive()`

BREAKING CHANGE: `octokit.repos.getContents()` has been renamed to `octokit.repos.getContent()`

BREAKING CHANGE: `octokit.repos.getHook()` has been renamed to `octokit.repos.getWebhook()`

BREAKING CHANGE: `octokit.repos.getProtectedBranchAdminEnforcement()` has been renamed to `octokit.repos.getAdminBranchProtection()`

BREAKING CHANGE: `octokit.repos.getProtectedBranchPullRequestReviewEnforcement()` has been renamed to `octokit.repos.getPullRequestReviewProtection()`

BREAKING CHANGE: `octokit.repos.getProtectedBranchRequiredSignatures()` has been renamed to `octokit.repos.getCommitSignatureProtection()`

BREAKING CHANGE: `octokit.repos.getProtectedBranchRequiredStatusChecks()` has been renamed to `octokit.repos.getStatusChecksProtection()`

BREAKING CHANGE: `octokit.repos.getProtectedBranchRestrictions()` has been renamed to `octokit.repos.getAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.list()` has been renamed to `octokit.repos.listForAuthenticatedUser()`

BREAKING CHANGE: `octokit.repos.listAssetsForRelease()` has been renamed to `octokit.repos.listReleaseAssets()`

BREAKING CHANGE: `octokit.repos.listCommitComments()` has been renamed to `octokit.repos.listCommitCommentsForRepo()`

BREAKING CHANGE: `octokit.repos.listHooks()` has been renamed to `octokit.repos.listWebhooks()`

BREAKING CHANGE: `octokit.repos.listProtectedBranchRequiredStatusChecksContexts()` has been renamed to `octokit.repos.getAllStatusCheckContexts()`

BREAKING CHANGE: `octokit.repos.listStatusesForRef()` has been renamed to `octokit.repos.listCommitStatusesForRef()`

BREAKING CHANGE: `octokit.repos.listTopics()` has been renamed to `octokit.repos.getAllTopics()`

BREAKING CHANGE: `octokit.repos.pingHook()` has been renamed to `octokit.repos.pingWebhook()`

BREAKING CHANGE: `octokit.repos.removeBranchProtection()` has been renamed to `octokit.repos.deleteBranchProtection()`

BREAKING CHANGE: `octokit.repos.removeDeployKey()` has been renamed to `octokit.repos.deleteDeployKey()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchAdminEnforcement()` has been renamed to `octokit.repos.deleteAdminBranchProtection()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchAppRestrictions()` has been renamed to `octokit.repos.removeAppAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchPullRequestReviewEnforcement()` has been renamed to `octokit.repos.deletePullRequestReviewProtection()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchRequiredSignatures()` has been renamed to `octokit.repos.deleteCommitSignatureProtection()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchRequiredStatusChecks()` has been renamed to `octokit.repos.removeStatusChecksProtection()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchRequiredStatusChecksContexts()` has been renamed to `octokit.repos.removeStatusCheckContexts()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchRestrictions()` has been renamed to `octokit.repos.deleteAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchTeamRestrictions()` has been renamed to `octokit.repos.removeTeamAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.removeProtectedBranchUserRestrictions()` has been renamed to `octokit.repos.removeUserAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.replaceProtectedBranchAppRestrictions()` has been renamed to `octokit.repos.setAppAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.replaceProtectedBranchRequiredStatusChecksContexts()` has been renamed to `octokit.repos.setStatusCheckContexts()`

BREAKING CHANGE: `octokit.repos.replaceProtectedBranchTeamRestrictions()` has been renamed to `octokit.repos.setTeamAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.replaceProtectedBranchUserRestrictions()` has been renamed to `octokit.repos.setUserAccessRestrictions()`

BREAKING CHANGE: `octokit.repos.replaceTopics()` has been renamed to `octokit.repos.replaceAllTopics()`

BREAKING CHANGE: `octokit.repos.requestPageBuild()` has been renamed to `octokit.repos.requestPagesBuild()`

BREAKING CHANGE: `octokit.repos.retrieveCommunityProfileMetrics()` has been renamed to `octokit.repos.getCommunityProfileMetrics()`

BREAKING CHANGE: `octokit.repos.testPushHook()` has been renamed to `octokit.repos.testPushWebhook()`

BREAKING CHANGE: `octokit.repos.updateHook()` has been renamed to `octokit.repos.updateWebhook()`

BREAKING CHANGE: `octokit.repos.updateProtectedBranchPullRequestReviewEnforcement()` has been renamed to `octokit.repos.updatePullRequestReviewProtection()`

BREAKING CHANGE: `octokit.repos.updateProtectedBranchRequiredStatusChecks()` has been renamed to `octokit.repos.updateStatusChecksProtection()`

BREAKING CHANGE: `octokit.teams.addOrUpdateMembershipInOrg()` has been renamed to `octokit.teams.addOrUpdateMembershipForUserInOrg()`

BREAKING CHANGE: `octokit.teams.addOrUpdateProjectInOrg()` has been renamed to `octokit.teams.addOrUpdateProjectPermissionsInOrg()`

BREAKING CHANGE: `octokit.teams.addOrUpdateRepoInOrg()` has been renamed to `octokit.teams.addOrUpdateRepoPermissionsInOrg()`

BREAKING CHANGE: `octokit.teams.checkManagesRepoInOrg()` has been renamed to `octokit.teams.checkPermissionsForRepoInOrg()`

BREAKING CHANGE: `octokit.teams.getMembershipInOrg()` has been renamed to `octokit.teams.getMembershipForUserInOrg()`

BREAKING CHANGE: `octokit.teams.removeMembershipInOrg()` has been renamed to `octokit.teams.removeMembershipForUserInOrg()`

BREAKING CHANGE: `octokit.teams.reviewProjectInOrg()` has been renamed to `octokit.teams.checkPermissionsForProjectInOrg()`

BREAKING CHANGE: `octokit.users.addEmails()` has been renamed to `octokit.users.addEmailsForAuthenticated()`

BREAKING CHANGE: `octokit.users.checkFollowing()` has been renamed to `octokit.users.checkPersonIsFollowedByAuthenticated()`

BREAKING CHANGE: `octokit.users.createGpgKey()` has been renamed to `octokit.users.createGpgKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.createPublicKey()` has been renamed to `octokit.users.createPublicSshKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.deleteEmails()` has been renamed to `octokit.users.deleteEmailsForAuthenticated()`

BREAKING CHANGE: `octokit.users.deleteGpgKey()` has been renamed to `octokit.users.deleteGpgKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.deletePublicKey()` has been renamed to `octokit.users.deletePublicSshKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.getGpgKey()` has been renamed to `octokit.users.getGpgKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.getPublicKey()` has been renamed to `octokit.users.getPublicSshKeyForAuthenticated()`

BREAKING CHANGE: `octokit.users.listBlocked()` has been renamed to `octokit.users.listBlockedByAuthenticated()`

BREAKING CHANGE: `octokit.users.listEmails()` has been renamed to `octokit.users.listEmailsForAuthenticated()`

BREAKING CHANGE: `octokit.users.listFollowingForAuthenticatedUser()` has been renamed to `octokit.users.listFollowedByAuthenticated()`

BREAKING CHANGE: `octokit.users.listGpgKeys()` has been renamed to `octokit.users.listGpgKeysForAuthenticated()`

BREAKING CHANGE: `octokit.users.listPublicEmails()` has been renamed to `octokit.users.listPublicEmailsForAuthenticatedUser()`

BREAKING CHANGE: `octokit.users.listPublicKeys()` has been renamed to `octokit.users.listPublicSshKeysForAuthenticated()`

BREAKING CHANGE: `octokit.users.togglePrimaryEmailVisibility()` has been renamed to `octokit.users.setPrimaryEmailVisibilityForAuthenticated()`

@gr2m gr2m added the Type: Feature New feature or request label Jun 10, 2020
@gr2m gr2m force-pushed the remove-deprecated-methods branch from 781a27c to cb06e31 Compare June 10, 2020 19:27
@gr2m
Copy link
Contributor Author

gr2m commented Jun 10, 2020

I want to review @octokit/core and the other plugins if there are other deprecations that can be removed.

@gr2m gr2m force-pushed the remove-deprecated-methods branch from cb06e31 to 97a093a Compare June 11, 2020 19:20
@gr2m gr2m merged commit b4ab0db into master Jun 11, 2020
@gr2m gr2m deleted the remove-deprecated-methods branch June 11, 2020 19:24
@github-actions
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Haroenv added a commit to algolia/shipjs that referenced this pull request Apr 5, 2022
eunjae-lee pushed a commit to algolia/shipjs that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant