-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Cms\Facades\Cms" extension is not enabled (Fix coming Jul/Aug '17) #2908
Comments
Hmm, looks like your composer is pulling down a "too new" version of Twig. Try specifying an explicit version in your composer.json before composer update.
|
@daftspunk LEGEND been pulling my hair out for hours |
Excuse my continued ignorance, but which |
I thought we fixed this in #2595 so I'm not really sure why its come back. |
Yep so we determined that this is fixed by opening
Then perform |
Just wanted to drop a note that the error vanished for me when I went to Unfortunately I tried both at the same time so I'm not sure if the permissions alone fix it already. I'm guessing it's more the update thing though because that might also update the vendor packages. |
Set Twig to version 1.34.* does not work in my project, sadly. Does this problem only concern an Octobercms install trough Composer (only)? |
The installation and updating trough Composer does not seem to work correctly anymore. I cannot get a working installation, after a
Updating trough the backend does work correctly. But I have to install a lot more with Composer. Therefore I don't want to break my update flow with Composer. This works: |
Should be 1.33.* see above |
@seanthepottingshed or @ametad have you tried setting it to |
@LukeTowers It all works for me, I was just pointing out to @ametad that actually @daftspunk stated to set the Twig dependency to |
Ah, gotcha. I would suggest |
@LukeTowers Cheers ears! |
@daftspunk @LukeTowers, I don't understand why that fix isn't going to be posted in the interim. 1-2 months seems like a long time for this to linger... |
@petehalverson No more builds are going to be released until the Laravel 5.5 upgrade, but I suppose we could replace https://github.com/octobercms/library/blob/master/composer.json#L25 with |
Shoot.. I overlooked the correct version being 1.33! Thank you! |
Testing it now, but this should be fixed for new composer installs of october |
Not fixed yet, packagist hasn't updated their tag reference to octobercms/library yet, will discuss with @daftspunk https://packagist.org/packages/october/rain#v1.0.419 |
It looks like dev-master has 1.33.* |
Yeah, but it goes off the build tag, which theoretically has been updated to point at dev-master's most recent commit |
Thanks @LukeTowers and @daftspunk. Tested it this morning and our docker build is now pulling the corrected Twig version: https://travis-ci.org/aspendigital/docker-octobercms/jobs/232636840#L2257 |
Expected behavior
Running the following from the command line:
composer create-project october/october TestInstall
cd TestInstall
php artisan october:install
...should create a working install of OctoberCMS
Actual behavior
Reproduce steps
As above
October build
419
The text was updated successfully, but these errors were encountered: