Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cms\Facades\Cms" extension is not enabled (Fix coming Jul/Aug '17) #2908

Closed
seanthepottingshed opened this issue Jun 6, 2017 · 22 comments
Closed

Comments

@seanthepottingshed
Copy link

Expected behavior

Running the following from the command line:

  • composer create-project october/october TestInstall
  • cd TestInstall
  • php artisan october:install
  • The entering responses to prompts

...should create a working install of OctoberCMS

Actual behavior

screen shot 2017-06-06 at 09 51 56

Reproduce steps

As above

October build

419

@daftspunk
Copy link
Member

Hmm, looks like your composer is pulling down a "too new" version of Twig. Try specifying an explicit version in your composer.json before composer update.

"twig/twig": "~1.23"

@seanthepottingshed
Copy link
Author

@daftspunk LEGEND been pulling my hair out for hours

@seanthepottingshed
Copy link
Author

Excuse my continued ignorance, but which composer.json should I be editing? And why has this only just started to occur?

@daftspunk
Copy link
Member

I thought we fixed this in #2595 so I'm not really sure why its come back.

@daftspunk
Copy link
Member

Yep so we determined that this is fixed by opening composer.json in the root directory, adding to the require object this value:

"twig/twig": "1.33.*",

Then perform composer update to rectify the breaking package. This will be fixed in Build 420+ as we move to Twig 2.0. This upgrade won't occur for at least 1-2 months. Leaving this open until then.

@daftspunk daftspunk changed the title Command Line Install No Longer Works Command Line composer create-project october/october not working (Fix coming Jul/Aug '17) Jun 6, 2017
@Harti
Copy link
Contributor

Harti commented Jun 6, 2017

Just wanted to drop a note that the error vanished for me when I went to /backend/system/updates, updated October and set chmod -R 777 in the october installation folder.

Unfortunately I tried both at the same time so I'm not sure if the permissions alone fix it already. I'm guessing it's more the update thing though because that might also update the vendor packages.

@LukeTowers LukeTowers changed the title Command Line composer create-project october/october not working (Fix coming Jul/Aug '17) "Cms\Facades\Cms" extension is not enabled (Fix coming Jul/Aug '17) Jun 6, 2017
@ametad
Copy link
Contributor

ametad commented Jun 13, 2017

Set Twig to version 1.34.* does not work in my project, sadly. Does this problem only concern an Octobercms install trough Composer (only)?

@ametad
Copy link
Contributor

ametad commented Jun 13, 2017

The installation and updating trough Composer does not seem to work correctly anymore. I cannot get a working installation, after a $ composer update the October project is not working anymore and gives the error

"Cms\Facades\Cms" extension is not enabled

Updating trough the backend does work correctly. But I have to install a lot more with Composer. Therefore I don't want to break my update flow with Composer.

This works:
Set "twig/twig": "1.23.*" and this will drop october/rain to version v1.0.390. Then the project instance will work.

@seanthepottingshed
Copy link
Author

Should be 1.33.* see above

@LukeTowers
Copy link
Contributor

@seanthepottingshed or @ametad have you tried setting it to ~1.33?

@seanthepottingshed
Copy link
Author

@LukeTowers It all works for me, I was just pointing out to @ametad that actually @daftspunk stated to set the Twig dependency to 1.33.* #2908 (comment)

@LukeTowers
Copy link
Contributor

Ah, gotcha. I would suggest ~1.33 for future support though, but it's moot when 5.5 gets released anyways.

@seanthepottingshed
Copy link
Author

@LukeTowers Cheers ears!

mnvx added a commit to mnvx/zabor that referenced this issue Jun 14, 2017
@petehalverson
Copy link
Contributor

petehalverson commented Jun 16, 2017

@daftspunk @LukeTowers, I don't understand why that fix isn't going to be posted in the interim. 1-2 months seems like a long time for this to linger...

@LukeTowers
Copy link
Contributor

@petehalverson No more builds are going to be released until the Laravel 5.5 upgrade, but I suppose we could replace https://github.com/octobercms/library/blob/master/composer.json#L25 with 1.33.* @daftspunk thoughts?

daftspunk added a commit to octobercms/library that referenced this issue Jun 17, 2017
@ametad
Copy link
Contributor

ametad commented Jun 18, 2017

Shoot.. I overlooked the correct version being 1.33! Thank you!

@LukeTowers
Copy link
Contributor

Testing it now, but this should be fixed for new composer installs of october

@LukeTowers
Copy link
Contributor

Not fixed yet, packagist hasn't updated their tag reference to octobercms/library yet, will discuss with @daftspunk https://packagist.org/packages/october/rain#v1.0.419

@ifnull
Copy link

ifnull commented Jun 18, 2017

It looks like dev-master has 1.33.*

@ifnull
Copy link

ifnull commented Jun 18, 2017

@LukeTowers
Copy link
Contributor

Yeah, but it goes off the build tag, which theoretically has been updated to point at dev-master's most recent commit

@petehalverson
Copy link
Contributor

Thanks @LukeTowers and @daftspunk. Tested it this morning and our docker build is now pulling the corrected Twig version: https://travis-ci.org/aspendigital/docker-octobercms/jobs/232636840#L2257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants