Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Lwt_io.delete_recursively #984

Merged

Conversation

MisterDA
Copy link
Contributor

Slight variations of this code are getting duplicated across our codebase, maybe it's best to expose it at the root in Lwt? Would another name better fit the function?

Copy link
Collaborator

@raphael-proust raphael-proust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the doc suggestion I made. I can merge with the fix if it works for you.

src/unix/lwt_io.mli Outdated Show resolved Hide resolved
@MisterDA MisterDA force-pushed the expose-lwt-io-delete-recursively branch from 845e868 to 27793da Compare February 21, 2023 11:01
@MisterDA
Copy link
Contributor Author

I've merged your doc fix into the first commit. All is fine by me!

@raphael-proust raphael-proust merged commit c70e8b6 into ocsigen:master Feb 21, 2023
@MisterDA MisterDA deleted the expose-lwt-io-delete-recursively branch February 21, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants