Export reraise, document recommended use #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following the recommendations of this MR, we get backtraces which are quite close to the ppx equivalent. There is still a little bit more noise in the form of additional occurrences of A minor difference is that the "Re-raised" entries have the location of the (Of course, the ppx is still useful for accessing all the additional keywords like |
raphael-proust
force-pushed
the
export-reraise-and-update-recommendations
branch
from
7749826
to
242e2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better backtrace management primitive and recommendations.
On a dummy example, I manage to obtain accurate backtrace information. Will test on more realistic examples as well.