Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error and a typo in the manual. #559

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Fix an error and a typo in the manual. #559

merged 1 commit into from
Mar 6, 2018

Conversation

jasone
Copy link
Contributor

@jasone jasone commented Mar 6, 2018

No description provided.

Copy link
Contributor

@hcarty hcarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small correction to the ppx syntax.

doc/manual.wiki Outdated
@@ -345,7 +345,7 @@ let log msg =
in
Lwt_io.printlf "%s: %s" thread_id msg

lwt () =
let lwt =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be let%lwt () = ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for helping me learn the right way to do it along the way. :)

@aantron aantron merged commit c3cdfb3 into ocsigen:master Mar 6, 2018
@aantron
Copy link
Collaborator

aantron commented Mar 6, 2018

Thanks!

@aantron
Copy link
Collaborator

aantron commented Mar 6, 2018

@jasone, off-topic, but I believe your fork is fork 100 of Lwt, and your PR triggered build 1000 in AppVeyor. You're the lucky winner! (No scam, I promise :p)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants