Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Lwt even more welcoming to new contributors (CONTRIBUTING.md) #379

Merged
merged 1 commit into from
May 31, 2017

Conversation

aantron
Copy link
Collaborator

@aantron aantron commented May 24, 2017

Let's continue making Lwt more welcoming to contributors. This PR adds some basic contributing documentation:

These should be considered as drafts; I just can't keep looking directly at them – feeling a sort of "writing lock" from thinking about them for days straight :) Maybe others have some fresh ideas :)

I've also added:

Easy issues should usually be left for new contributors. They should contain a thorough description of how to do the change, including testing.

I plan to later add guides on specific tasks to CONTRIBUTING.md. Ideally, this would make some otherwise-difficult issues easy, as contributors can be linked to the guides, and can then follow them rather closely. Potential topics for guides:

  • How to make a non-blocking function binding (e.g. for the current getcwd issue.
  • How to make/prepare for a breaking change.
  • How to find users of a particular API in OPAM by searching the reverse dependencies.

cc @vramana: thanks for linking me to that video full of ideas. I'd appreciate your thoughts on this :)

@aantron aantron added the docs label May 24, 2017
@vramana
Copy link

vramana commented May 25, 2017

Awesome work. This looks so much more contributor friendly. For some more inspiration you can look at this https://github.com/sympy/sympy/wiki#development

We need a way to surface these easy issues and so that more people contrbute. May be we can do weekly thread on discuss.ocaml.org where projects can post new contributor friendly issues. @avsm any thoughts?

@aantron aantron merged commit e1b7732 into master May 31, 2017
aantron added a commit that referenced this pull request Jun 1, 2017
This is to avoid GitHub showing a warning to read CONTRIBUTING.md when
one is creating a new issue. The current CONTRIBUTING.md does not
contain any information relevant to creating new issues.

Related #379.

[skip ci]
aantron added a commit that referenced this pull request Jun 1, 2017
@aantron aantron deleted the contributing branch June 12, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants