enhance/fix invalid argument exception string payload #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
reviewed
May 22, 2017
src/unix/lwt_bytes.ml
Outdated
| @@ -60,23 +60,23 @@ let blit_from_bytes src_buf src_ofs dst_buf dst_ofs len = | |||
| if (len < 0 | |||
| || src_ofs < 0 || src_ofs > Bytes.length src_buf - len | |||
| || dst_ofs < 0 || dst_ofs > length dst_buf - len) then | |||
| invalid_arg "String.blit" | |||
| invalid_arg "Lwt_bytes.blit" | |||
There was a problem hiding this comment.
Should this be "Lwt_bytes.blit_from_bytes"?
src/unix/lwt_bytes.ml
Outdated
| else | ||
| unsafe_blit_from_bytes src_buf src_ofs dst_buf dst_ofs len | ||
|
|
||
| let blit_to_bytes src_buf src_ofs dst_buf dst_ofs len = | ||
| if (len < 0 | ||
| || src_ofs < 0 || src_ofs > length src_buf - len | ||
| || dst_ofs < 0 || dst_ofs > Bytes.length dst_buf - len) then | ||
| invalid_arg "String.blit" | ||
| invalid_arg "Lwt_bytes.blit" |
There was a problem hiding this comment.
...and this "Lwt_bytes.blit_to_bytes"?
There was a problem hiding this comment.
and yes
see new commit
|
Thanks again! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.