-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace establish_server by establish_server_safe #260
Labels
Comments
aantron
added a commit
that referenced
this issue
Oct 20, 2016
This function will replace Lwt_io.establish_server. It's better if users don't refer to it by its current name. The current Lwt_io.establish_server will go through some deprecation process once 4.01 support is dropped. See #260. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lwt_io.establish_server_safe
closes channels automatically and was introduced in #258. I looked at users of the originalestablish_server
in OPAM (as of today), and none would be negatively affected by closing channels automatically. Hopefully, this also holds true of most or all non-OPAM users.The signatures are incompatible, so code would have to be adjusted:
The text was updated successfully, but these errors were encountered: