feat!: version 3 (#387)

* feat!: version 3 BREAKING CHANGE: node 18+, fancy-test v3 * chore: update github workflows * chore(release): 2.5.7-beta.0 [skip ci] * chore: major version bump * chore(release): 3.0.0-beta.1 [skip ci] * chore: pass token to automerge * chore: bump chai to resolve dependabot vuln --------- Co-authored-by: svc-cli-bot <[email protected]> Co-authored-by: mshanemc <[email protected]>
oclif · Sep 28, 2023 · dd9a700 · dd9a700
1 parent 8e23231
commit dd9a700
Show file tree

Hide file tree

Showing 13 changed files with 1,232 additions and 880 deletions.
diff --git a/.eslintrc → .eslintrc.json b/.eslintrc → .eslintrc.json
diff --git a/.github/workflows/automerge.yml b/.github/workflows/automerge.yml
@@ -2,9 +2,10 @@ name: automerge
 on:
  workflow_dispatch:
  schedule:
- - cron: '17 2,5,8,11 * * *'
+ - cron: "17 2,5,8,11 * * *"
 
 jobs:
  automerge:
  uses: salesforcecli/github-workflows/.github/workflows/automerge.yml@main
- secrets: inherit
+ secrets:
+ SVC_CLI_BOT_GITHUB_TOKEN: ${{ secrets.SVC_CLI_BOT_GITHUB_TOKEN }}
diff --git a/.github/workflows/manualRelease.yml b/.github/workflows/manualRelease.yml
diff --git a/.github/workflows/onPushToMain.yml b/.github/workflows/onPushToMain.yml
diff --git a/README.md b/README.md
@@ -4,7 +4,6 @@
 test helpers for oclif components
 
 [![Version](https://img.shields.io/npm/v/@oclif/test.svg)](https://npmjs.org/package/@oclif/test)
-[![CircleCI](https://circleci.com/gh/oclif/test/tree/main.svg?style=svg)](https://circleci.com/gh/oclif/test/tree/main)
 [![Known Vulnerabilities](https://snyk.io/test/npm/@oclif/test/badge.svg)](https://snyk.io/test/npm/@oclif/test)
 [![Downloads/week](https://img.shields.io/npm/dw/@oclif/test.svg)](https://npmjs.org/package/@oclif/test)
 [![License](https://img.shields.io/npm/l/@oclif/test.svg)](https://github.com/oclif/test/blob/main/package.json)
diff --git a/greenkeeper.json b/greenkeeper.json
diff --git a/package.json b/package.json
@@ -1,30 +1,31 @@
 {
  "name": "@oclif/test",
  "description": "test helpers for oclif components",
- "version": "2.5.6",
+ "version": "3.0.0-beta.1",
  "author": "Salesforce",
  "bugs": "https://github.com/oclif/test/issues",
  "dependencies": {
- "@oclif/core": "^2.15.0",
- "fancy-test": "^2.0.42"
+ "@oclif/core": "^3.0.0-beta.17",
+ "fancy-test": "^3.0.1"
  },
  "devDependencies": {
  "@types/chai": "^4.3.6",
- "@types/mocha": "^9.1.1",
- "@types/node": "^14.18.63",
- "chai": "^4.3.8",
- "eslint": "^7.32.0",
- "eslint-config-oclif": "^4.0.0",
- "eslint-config-oclif-typescript": "^1.0.3",
+ "@types/mocha": "^10",
+ "@types/node": "^18",
+ "chai": "^4.3.10",
+ "eslint": "^8.49.0",
+ "eslint-config-oclif": "^5.0.0",
+ "eslint-config-oclif-typescript": "^2.0.1",
  "globby": "^11.0.1",
- "mocha": "^9",
+ "mocha": "^10",
  "nock": "^13.3.3",
  "shx": "^0.3.3",
- "ts-node": "^9.0.0",
- "typescript": "4.6.4"
+ "ts-node": "^10.9.1",
+ "tslib": "^2.6.2",
+ "typescript": "^5"
  },
  "engines": {
- "node": ">=12.0.0"
+ "node": ">=18.0.0"
  },
  "files": [
  "/lib"
@@ -38,11 +39,11 @@
  "repository": "oclif/test",
  "scripts": {
  "build": "shx rm -rf lib && tsc",
- "lint": "eslint . --ext .ts --config .eslintrc",
+ "lint": "eslint . --ext .ts",
  "posttest": "yarn lint",
  "prepublishOnly": "yarn run build",
  "test": "mocha --forbid-only \"test/**/*.test.ts\"",
  "pretest": "yarn build --noEmit && tsc -p test --noEmit"
  },
  "types": "lib/index.d.ts"
-}
+}
diff --git a/src/index.ts b/src/index.ts
@@ -1,7 +1,6 @@
-import path from 'path'
+import {dirname} from 'node:path'
 
-import {Config} from '@oclif/core'
-import {expect, fancy, FancyTypes} from 'fancy-test'
+import {fancy} from 'fancy-test'
 
 import {command} from './command'
 import exit from './exit'
@@ -11,7 +10,7 @@ import {loadConfig} from './load-config'
 function traverseFilePathUntil(filename: string, predicate: (filename: string) => boolean): string {
  let current = filename
  while (!predicate(current)) {
- current = path.dirname(current)
+ current = dirname(current)
  }
 
  return current
@@ -30,9 +29,7 @@ export const test = fancy
 
 export default test
 
-export {
- expect,
- FancyTypes,
- Config,
- command,
-}
+export {Config} from '@oclif/core'
+export {expect, FancyTypes} from 'fancy-test'
+
+export {command} from './command'
diff --git a/test/command.test.ts b/test/command.test.ts
@@ -1,9 +1,9 @@
-import * as path from 'path'
+import {join} from 'node:path'
 
 import {expect, test} from '../src'
 
 // eslint-disable-next-line unicorn/prefer-module
-const root = path.join(__dirname, 'fixtures/multi')
+const root = join(__dirname, 'fixtures/multi')
 
 describe('command', () => {
  test

diff --git a/test/exit.test.ts b/test/exit.test.ts
@@ -1,8 +1,9 @@
-import * as path from 'path'
+import {join} from 'node:path'
 
 import {expect, test} from '../src'
 
-const root = path.join(__dirname, 'fixtures/multi')
+// eslint-disable-next-line unicorn/prefer-module
+const root = join(__dirname, 'fixtures/multi')
 
 describe('exit', () => {
  test

diff --git a/test/hook.test.ts b/test/hook.test.ts
@@ -1,8 +1,9 @@
-import * as path from 'path'
+import {join} from 'node:path'
 
 import {expect, test} from '../src'
 
-const root = path.join(__dirname, 'fixtures/multi')
+// eslint-disable-next-line unicorn/prefer-module
+const root = join(__dirname, 'fixtures/multi')
 
 describe('hooks', () => {
  test

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -40,7 +40,7 @@ class MockOs {
 for (const os of ['darwin', 'win32', 'linux']) {
  describe(os, () => {
  test
- .stub(MockOs, 'platform', () => os)
+ .stub(MockOs, 'platform', stub => stub.returns(os))
  .end('sets os', () => {
  expect(MockOs.platform()).to.equal(os)
  })