feat: create symlinks from binAliases to bin for pack:macos #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
force-pushed
the
wr/symlinkBinAliases
branch
from
4bc43e2
to
24817b3
Compare
mdonnalley
previously approved these changes
Feb 21, 2023
There was a problem hiding this comment.
QA
Steps:
- Link oclif/core to oclif
- Link oclif/core & oclif to salesforcecli/cli
- Add
binAliasesto sf package.json - Run
yarn pack:macosfrom sf repo - Open arm64 .pkg in dist/macos
✅ Can run sf --version
✅ Can run sf-alias --version
- Run uninstaller (
sudo /usr/local/lib/sf/bin/uninstall)
✅ sf doesn't exist
✅ sf-alias doesn't exist
mdonnalley
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-12545440@
adds symlinks from the
binAliasessection in pjsonrequires: oclif/core#632