allow flags to have false value in when #557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have certain scenarios where we want to disallow users from using a
--no
flag when another flag is present. It seems we can do this by checking the value of the flag we want to disallow inwhen
, but it ignoresfalse
values.Flags
Execution
With this PR, the above will throw an error.
Related Issue
Closes #556
Currently a draft PR, because this was added without any tests failing and only one case has been added.