Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newFeature: Add configuration option to control case-insensitive under oracle tenant #65

Merged
merged 10 commits into from
May 15, 2024

Conversation

yuanoOo
Copy link
Collaborator

@yuanoOo yuanoOo commented May 14, 2024

Summary

close #64

Solution Description

  • This issue only exists under oracle tenant
  • There are no integration tests in the code since OceanBase enterprise version doesn't seem to provide a docker image.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@whhe
Copy link
Member

whhe commented May 14, 2024

Thanks for your contribution! I left some comments.

Before merging this pr, you also need to sign the CLA following the CLAassistant's comment above. And it's also necessary to add an integrated test case for the new introcuded option.

@yuanoOo
Copy link
Collaborator Author

yuanoOo commented May 14, 2024

Thanks for your contribution! I left some comments.

Before merging this pr, you also need to sign the CLA following the CLAassistant's comment above. And it's also necessary to add an integrated test case for the new introcuded option.

  • 1、I have already signed the CLA, but the page keeps showing that I have not signed it...
  • 2、About integration testing, the oceanbase community version does not support Oracle tenants, and the enterprise version does not seem to provide docker images. Do you have any advice。

@whhe
Copy link
Member

whhe commented May 14, 2024

Thanks for your contribution! I left some comments.
Before merging this pr, you also need to sign the CLA following the CLAassistant's comment above. And it's also necessary to add an integrated test case for the new introcuded option.

  • 1、I have already signed the CLA, but the page keeps showing that I have not signed it...
  • 2、About integration testing, the oceanbase community version does not support Oracle tenants, and the enterprise version does not seem to provide docker images. Do you have any advice。

The CLA check is passed now. For testing part, you can add a test case, execute it locally but skip it in GitHub CI, just like OceanBaseOracleDynamicTableSinkITCase.

@whhe whhe merged commit 37186e4 into oceanbase:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add parameters to control handling of lowercase when SQL concatenation
3 participants