Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid head -c GNUism in reftests #5989

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Avoid head -c GNUism in reftests #5989

merged 1 commit into from
Jul 2, 2024

Conversation

madroach
Copy link

@madroach madroach commented Jun 4, 2024

head -c is not posix-compliant, use cut -b instead.

kit-ty-kate
kit-ty-kate approved these changes Jun 4, 2024
View reviewed changes
master_changes.md Outdated Show resolved Hide resolved
@kit-ty-kate
Copy link
Member

kit-ty-kate commented Jun 4, 2024 •
edited
Loading

the email you authored the commit with isn't recognised as part of your github profile. It's not a big deal but if you want you can amend your commit and/or add that email address to your github profile, and force-(with-lease-)push so it appears as yours

@rjbou rjbou added this to PR in Out of release : doc, test, install, etc. via automation Jun 6, 2024
rjbou
rjbou approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rjbou rjbou self-requested a review June 6, 2024 09:26
rjbou
rjbou requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing one in list.unix.test

@madroach
Copy link
Author

madroach commented Jun 6, 2024 •
edited
Loading

There is a missing one in list.unix.test

This one uses head -n 1, which is POSIX conforming. It's the -c 1 parameter, which is not POSIX conforming. This job is better left to cut.

@kit-ty-kate kit-ty-kate requested a review from rjbou June 6, 2024 22:59
@rjbou rjbou added this to PR in Progress in Opam 2.3 via automation Jun 27, 2024
@rjbou rjbou added this to the 2.3 milestone Jun 27, 2024
@kit-ty-kate
Avoid GNUism
a360728 
head -c is not posix-compliant, use cut -b instead.
@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 8018f2f into ocaml:master Jul 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
AREA:TEST STATE: READY TO MERGE
Projects
No open projects
Opam 2.3
  
PR in Progress
Out of release : doc, test, install, ...
PR
Milestone
2.3.0~alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@madroach @kit-ty-kate @rjbou