Open the release files for reading #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6704719
to
ac3ccf0
Compare
rjbou
reviewed
Jun 8, 2023
Fixes an issue where the release file is determined but the sscanf is ran on the filename, not its contents, thus giving invalid results.
c11f43e
to
a03ed45
Compare
rjbou
approved these changes
Jun 8, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the release file is determined but the sscanf is ran on the filename, not its contents, thus giving invalid results.
Detected as part of working on ocaml/dune#7868 which triggered looking into the implementation and discussed with @rjbou.
I could only test it on Fedora 38, where
/etc/redhad-releasecontains the following: