Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package mccs.1.1+2 #10075

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Package mccs.1.1+2 #10075

merged 1 commit into from
Aug 22, 2017

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Aug 11, 2017

mccs.1.1+2

Multi Criteria CUDF Solver with OCaml bindings

This is a stripped-down version of the mccs solver (written in C++), including
OCaml bindings based on the cudf library. Note that it includes some correctness
fixes, and a few changes not present in the upstream yet.



🐫 Pull-request generated by opam-publish v0.3.5

@AltGr AltGr mentioned this pull request Aug 11, 2017
@camelus
Copy link
Contributor

camelus commented Aug 11, 2017

✅ All lint checks passed 2304c7c
  • These packages passed lint tests: mccs.1.1+2

✅ Installability check (7274 → 7275)
  • new installable packages (1): mccs.1.1+2

@yallop
Copy link
Member

yallop commented Aug 14, 2017

The build's failing on (I think) Debian:

-   ocamlmklib src/dllmccs_stubs.so,src/libmccs_stubs.a (exit 2)
- (cd _build/default && /home/opam/.opam/4.04.2/bin/ocamlmklib.opt -g -o src/mccs_stubs src/changed_criteria.o src/constraint_generation.o src/count_criteria.o src/cudf_reductions.o src/cudf_tools.o src/glpk_solver.o src/lexagregate_combiner.o src/new_criteria.o src/notuptodate_criteria.o src/removed_criteria.o src/mccscudf.o src/mccs_stubs.o -lz -lltdl -lglpk -lstdc++)
- /usr/bin/ld: cannot find -lltdl
- collect2: error: ld returned 1 exit status

Is there a missing libtool (or perhaps libltdl-dev) depext?

@AltGr
Copy link
Member Author

AltGr commented Aug 15, 2017

Ah, thanks for looking that up. Actually the link flag isn't needed, we just need glpk, ltdl somehow got picked up automatically on my system but we don't need to specify it anyway. Fixed.

@AltGr
Copy link
Member Author

AltGr commented Aug 16, 2017

Failures on Alpine and CentOS 7: it appears they don't have glpk packaged. CentOS has lpsolve, that we could use instead as backend for mccs (it's slower, on my limited experiments, though). Alpine doesn't appear to have anything we can use.
What is the policy in this case ? We don't have a depext flag to explicitely mark the dependency as missing. Making the package unavailable altogether would be also wrong, because the user could get the dependencies by hand.

@AltGr
Copy link
Member Author

AltGr commented Aug 16, 2017

(anyway, the issues above concern the conf-glpk package, not this one: I think this is good for merge)
The failure on Alpine is very suspicious, though, since conf-glpk apparently installed successfully (and then mccs failed to link). Is conf-glpk broken ? Here is the conf line:

cc "-c" "-l:libglpk.a" (CWD=/home/opam/.opam/4.04.2/build/conf-glpk.1)

@avsm avsm merged commit 95de857 into ocaml:master Aug 22, 2017
@avsm
Copy link
Member

avsm commented Aug 22, 2017

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants