Breadcrumbs + 2-level module path #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it's hard to test this before #149 is merged, this is how it looks: |
|
What are "breadcrumbs"? I haven't been following... |
|
See: Breadcrumb (navigation). |
|
Ah! I like this! |
The links allow you to jump higher in the hierarchy, giving a better ability to navigate.
|
@aantron I think this looks good enough to merge now. We can improve the style later as needed. |
|
Ok, just going to update the expect tests, then will merge it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than put the links in the title, I followed @rizo's suggestion and created breadcrumbs, restricting the module path in the title to 2 levels to avoid overflow. I think this looks good, though it could use some styling.