Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search entries for module aliases return dead links #1106

Closed
lpw25 opened this issue Mar 28, 2024 · 0 comments · Fixed by #1108
Closed

Search entries for module aliases return dead links #1106

lpw25 opened this issue Mar 28, 2024 · 0 comments · Fixed by #1108

Comments

@lpw25
Copy link
Contributor

lpw25 commented Mar 28, 2024

Searching for Throttle in Async at https://ocaml.org or on https://doc.sherlocode.com produces an entry for Async.Throttle with a dead link to the url:

https://ocaml.org/p/async/v0.16.0/doc/Async/Throttle/index.html

it should instead link to:

https://ocaml.org/p/async_kernel/v0.16.0/doc/Async_kernel/Throttle/index.html

because Throttle in Async is just a module alias to Throttle in Async_kernel.

panglesd added a commit to panglesd/odoc that referenced this issue May 2, 2024
Otherwise, we can end up with 404 links. See ocaml#1106.

Signed-off-by: Paul-Elliot <[email protected]>
panglesd added a commit to panglesd/odoc that referenced this issue May 2, 2024
Otherwise, we can end up with 404 links. See ocaml#1106.

Signed-off-by: Paul-Elliot <[email protected]>
jonludlam pushed a commit that referenced this issue May 3, 2024
Otherwise, we can end up with 404 links. See #1106.

Signed-off-by: Paul-Elliot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant