Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load plugins from path specified by OBS_PLUGINS_PATH #4067

Merged

Conversation

abcdw
Copy link
Contributor

@abcdw abcdw commented Jan 14, 2021

Description

Allow to load obs plugins from custom directory, specified by
OBS_PLUGINS_PATH and OBS_PLUGINS_DATA_PATH environment variables.

Example usage:

OBS_PLUGINS_PATH=/opt/lib/obs-plugins OBS_PLUGINS_DATA_PATH=/opt/share/obs/obs-plugins obs

Motivation and Context

It's required to make it possible to package obs plugins using guix and nix package managers. Because in those package managers every package has it's own directory with the result of the build, it's not possible to relocate plugin's binaries to obs directory.

It will help to solve: NixOS/nixpkgs#77627

How Has This Been Tested?

Tested on Guix GNU/Linux, kernel 5.10.3, x1 yoga 4th laptop

  • Built a patched obs package for Guix GNU/Linux
  • Built wlrobs and specrtralizer plugins
  • Set enviroment variables, checked with strace that plugins are loaded and work as expected
    Those changes should not affect other obs subsystem, only plugin loading process.
  • Unset environment variables, checked that everything still works, but plugins not loaded.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Jan 14, 2021
UI/window-basic-main.cpp Outdated Show resolved Hide resolved
libobs/obs-nix.c Outdated Show resolved Hide resolved
Allow to load obs plugins from arbitary directory, specified by
OBS_PLUGINS_PATH and OBS_PLUGINS_DATA_PATH environment variables.
@jp9000 jp9000 force-pushed the plugin-paths-from-enviroment-varibles branch from 92f4d72 to a0b61bf Compare January 16, 2021 03:06
@jp9000 jp9000 merged commit fb347c3 into obsproject:master Jan 16, 2021
@abcdw
Copy link
Contributor Author

abcdw commented Jan 16, 2021

@jp9000 Cool. Thank a lot!

Can you put a 26.1.3 tag, please? It will simplify the process of accepting patches for obs package in Guix.

@RytoEX RytoEX added this to the OBS Studio 27.0 milestone Mar 20, 2021
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Sep 17, 2022
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Sep 17, 2022
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Sep 17, 2022
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Sep 17, 2022
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Sep 17, 2022
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Mar 27, 2023
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Mar 28, 2023
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Xaymar added a commit to Vhonowslend/StreamFX-Public that referenced this pull request Apr 5, 2023
Thanks to the PR by @abcdw (obsproject/obs-studio#4067) we can support 'local user' installations. These will allow end users to install StreamFX without requiring Administrator rights, or learning how to use OBS Studio in portable mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants