gods tree & barycentric fix #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Thanks. I’d prefer to use a shorter image for the tree, similar to the one we have on the documentation page. And if we’re going to use side-by-side images, we’ll want to put the before and after labels on the image itself so that it’s more obvious which is which without reading the text. (Or we could use separate before/after images like we did for the axes, but that is more suitable when the image is very short and wide.)
mbostock
approved these changes
Jun 27, 2023
mbostock
added a commit
that referenced
this pull request
Jun 27, 2023
* gods * fix barycentric * Update CHANGELOG --------- Co-authored-by: Mike Bostock <[email protected]>
mbostock
added a commit
that referenced
this pull request
Jun 28, 2023
* gods * fix barycentric * Update CHANGELOG --------- Co-authored-by: Mike Bostock <[email protected]>
mbostock
added a commit
that referenced
this pull request
Jun 28, 2023
* Update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md * gods tree & barycentric fix (#1729) * gods * fix barycentric * Update CHANGELOG --------- Co-authored-by: Mike Bostock <[email protected]> * Update CHANGELOG * leaner barycentric before/after image * Update CHANGELOG * Update CHANGELOG --------- Co-authored-by: Philippe Rivière <[email protected]>
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
* Update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md * gods tree & barycentric fix (#1729) * gods * fix barycentric * Update CHANGELOG --------- Co-authored-by: Mike Bostock <[email protected]> * Update CHANGELOG * leaner barycentric before/after image * Update CHANGELOG * Update CHANGELOG --------- Co-authored-by: Philippe Rivière <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* Update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md * gods tree & barycentric fix (observablehq#1729) * gods * fix barycentric * Update CHANGELOG --------- Co-authored-by: Mike Bostock <[email protected]> * Update CHANGELOG * leaner barycentric before/after image * Update CHANGELOG * Update CHANGELOG --------- Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.