Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default tickFormat with a collapsed domain lacks sufficient precision #2076

Open
mbostock opened this issue Jun 9, 2024 · 2 comments · May be fixed by d3/d3-scale#287
Open

The default tickFormat with a collapsed domain lacks sufficient precision #2076

mbostock opened this issue Jun 9, 2024 · 2 comments · May be fixed by d3/d3-scale#287
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

mbostock commented Jun 9, 2024

untitled - 2024-06-09T163705 855

Plot.ruleX([5.5]).plot()

We should probably fallback to formatAuto when there is a collapsed domain.
@mbostock mbostock added the bug Something isn’t working label Jun 9, 2024
@mbostock
Copy link
Member Author

Really a D3 bug…

d3.scaleLinear().domain([5.5, 5.5]).tickFormat(7.5)(5.5) // "6"

We don’t handle the tick step being zero well.

@Fil Fil mentioned this issue Jun 17, 2024
Open
@Fil
Copy link
Contributor

Fil commented Jun 17, 2024

moved to d3/d3-scale#286

Fil added a commit to d3/d3-scale that referenced this issue Jun 17, 2024
@Fil
fix tickFormat on a collapsed domain (start == end)
ddfa33e 
closes #286
closes observablehq/plot#2076
@Fil Fil linked a pull request Jun 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix tickFormat on a collapsed domain (start == end) d3/d3-scale
2 participants
@Fil @mbostock