mortage example edits #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Feb 14, 2024
| ], | ||
| caption: html`<span style="font-size: 11px">52 week range` | ||
| }); | ||
| return html`<div class="card"> |
There was a problem hiding this comment.
This didn’t work correctly because of the wrapper span. #11 In general we want to server-side render as much as we can, so I changed the card to be declared statically, and then render the contents as a fragment.
mbostock
commented
Feb 14, 2024
src/style/grid.css
Outdated
There was a problem hiding this comment.
This fixes some bugs with the responsive grid. Still want to switch to Tailwind at some point…
mbostock
commented
Feb 14, 2024
src/client/stdlib/resize.ts
Outdated
There was a problem hiding this comment.
This makes it so that you can have a resizable element within a card, rather than occupying the entire card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I aligned the layout to show more on the page and… be a bit prettier. 🙂