Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail tests on lint warnings #774

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Feb 13, 2024

No description provided.

@mythmon mythmon enabled auto-merge (squash) February 13, 2024 21:12
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want yarn test to fail locally, too, which means import order should be an error rather than a warning.

@mythmon
Copy link
Contributor Author

mythmon commented Feb 13, 2024

I personally get a lot of value from separating lints into correctness and style, where correctness is errors and style is warnings. It lets me ignore the style errors while I'm working and not break flow to figure out if I need to deal with an error right now or not. I can make yarn test fail either way though.

@mythmon mythmon changed the title fail CI on lint warnings fail tests on lint warnings Feb 13, 2024
@mythmon mythmon merged commit 12593fc into main Feb 13, 2024
2 checks passed
@mythmon mythmon deleted the mythmon/240213/warnings-mandatory branch February 13, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants