Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples gallery #772

Merged
merged 8 commits into from
Feb 13, 2024
Merged

examples gallery #772

merged 8 commits into from
Feb 13, 2024

Conversation

mbostock
Copy link
Member

No description provided.

@mbostock mbostock requested review from Fil and trebor February 13, 2024 19:49
@mbostock mbostock linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Fil
Copy link
Contributor

Fil commented Feb 13, 2024

the screen captures look fuzzy, could we take them in x2?

@mbostock
Copy link
Member Author

I think there’s some webp compression happening. Let me investigate.

@mbostock mbostock marked this pull request as ready for review February 13, 2024 20:24
@mbostock mbostock enabled auto-merge (squash) February 13, 2024 20:29
@mbostock mbostock merged commit ae1c8c6 into main Feb 13, 2024
2 checks passed
@mbostock mbostock deleted the trebor/examples-for-home branch February 13, 2024 20:30
@trebor
Copy link
Contributor

trebor commented Feb 14, 2024

the screen captures look fuzzy, could we take them in x2?

ya, the image assets, which i pulled from figma, were 592x462 png, and have been scaled up to 625x475 webp. i've created an issue to recapture them.

@mbostock
Copy link
Member Author

I already took new screenshots for everything @trebor. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add examples to home page
3 participants