Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #1487

Merged
merged 1 commit into from
Jun 27, 2024
Merged

typo #1487

merged 1 commit into from
Jun 27, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jun 26, 2024

(spotted by Gordon Tu, thanks!)

@Fil Fil requested a review from allisonhorst June 26, 2024 15:46
@Fil Fil enabled auto-merge (squash) June 26, 2024 15:46
@@ -295,7 +295,7 @@ In the future, Plot will support more interaction methods, including brushing. P

The `view` function does two things:

1. it [displays](../javascript#explicit-display) the given DOM *element*, and then
1. it [displays](<../javascript#display(value)>) the given DOM *element*, and then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary? Isn’t the original link valid?

https://observablehq.com/framework/javascript#explicit-display

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad!

@Fil Fil merged commit d76e803 into main Jun 27, 2024
8 checks passed
@Fil Fil deleted the fil/typo branch June 27, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants