Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a different path for deploy.json #1389

Merged
merged 5 commits into from
May 31, 2024

Conversation

mythmon
Copy link
Member

@mythmon mythmon commented May 23, 2024

Add a --deploy-config option to deploy, to allow specifying alternate paths for deploy.json. This can help support our examples, as well as users that want to maintain multiple deploys, such as stage and prod projects.

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This’ll be great — I’d like to find a way to use this for the examples so we can check-in the deploy.json without them needing to live in the example directory.

docs/deploying.md Outdated Show resolved Hide resolved
src/observableApiConfig.ts Outdated Show resolved Hide resolved
src/deploy.ts Outdated Show resolved Hide resolved
test/deploy-test.ts Outdated Show resolved Hide resolved
@mbostock
Copy link
Member

If this LGTY it LGTM. 👍

Looks like you’ll have a bit of a chore merging against #1295 though. 😬

@mythmon
Copy link
Member Author

mythmon commented May 31, 2024

I tried to merge this with git merge, and like you predicted it was looking pretty difficult to work with. Instead I reverted deploy.ts back to it's state on main, and manually applied all the changes from this branch to the right logical places. Much easier.

@mythmon
Copy link
Member Author

mythmon commented May 31, 2024

Thanks for the updates, and especially the doc changes.

@mythmon mythmon merged commit 8bce059 into main May 31, 2024
4 checks passed
@mythmon mythmon deleted the mythmon/240522/choosable-deploy-json branch May 31, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants