Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mssql to latest; Drop Node 14 support #88

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

prichey
Copy link
Contributor

@prichey prichey commented Dec 15, 2023

A transitive dependency of [email protected] (@azure/[email protected]) is incompatible with Node 20. This PR upgrades mssql to latest (10.0.1), which allows for Node 20 support.

The upgrade to mssql@10 requires dropping support for Node 14 (more here), which reached end of life in April 2023.

@prichey
Copy link
Contributor Author

prichey commented Dec 15, 2023

Tests are passing locally:

➜ docker-compose -f docker-compose.yml -f docker-compose.local.yml up test
[+] Building 0.0s (0/0)                              docker:desktop-linux
[+] Running 2/0
 ✔ Container database-proxy-mssql-1  Running                         0.0s
 ✔ Container database-proxy-test-1   Created                         0.0s
Attaching to database-proxy-test-1
database-proxy-test-1  | MS_SQL DB seeded.
database-proxy-test-1  |
database-proxy-test-1  |
database-proxy-test-1  |   mssql
database-proxy-test-1  |     when checking
database-proxy-test-1  |       with system admin user
database-proxy-test-1  |         ✔ should throw a too permissive error (125ms)
database-proxy-test-1  |     when querying
database-proxy-test-1  |       ✔ should stream the results of simple query (88ms)
database-proxy-test-1  |       ✔ should handle parameter graciously (98ms)
database-proxy-test-1  |       ✔ should replace cell reference in the SQL query (73ms)
database-proxy-test-1  |       ✔ should handle duplicated column names (143ms)
database-proxy-test-1  |       ✔ should select the last value of any detected duplicated columns (337ms)
database-proxy-test-1  |     when check the dataTypeSchema
database-proxy-test-1  |       ✔ should TYPES.Image.name to object
database-proxy-test-1  |
database-proxy-test-1  |
database-proxy-test-1  |   7 passing (939ms)

@@ -3,7 +3,7 @@ FROM node:18.12.1-alpine
RUN mkdir /app
WORKDIR /app

RUN apk --no-cache add bash
RUN apk --no-cache add bash git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously:

 > [test 6/7] RUN   yarn --frozen-lockfile &&   yarn cache clean:
4.721 yarn install v1.22.19
5.361 [1/5] Validating package.json...
5.367 [2/5] Resolving packages...
6.314 [3/5] Fetching packages...
6.688 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
6.688 error Couldn't find the binary git

@prichey prichey requested a review from visnup January 2, 2024 14:55
@prichey prichey merged commit 78d95cb into main Jan 5, 2024
@prichey prichey deleted the prichey/upgrade-mssql branch January 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants