Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no fields case #73

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix no fields case #73

merged 1 commit into from
Jan 31, 2023

Conversation

Sylvestre67
Copy link
Contributor

@Sylvestre67 Sylvestre67 commented Jan 31, 2023 •
edited
Loading

Sometimes there's no field. For example when running

FLUSHING PRIVILEGES;

@Sylvestre67 Sylvestre67 marked this pull request as ready for review January 31, 2023 20:42
@visnup
Copy link
Member

visnup commented Jan 31, 2023

so in this case, what does the notebook end up returning? it doesn't confuse DatabaseClient?

@Sylvestre67
Copy link
Contributor Author

An empty table with no columns and no row.

visnup
visnup approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@visnup visnup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a test for this, at least internally, and then ported into this repo eventually.

@Sylvestre67
Copy link
Contributor Author

Yeah I already have a PR for migrating the test here.

@Sylvestre67 Sylvestre67 merged commit 14aeb83 into main Jan 31, 2023
@Sylvestre67 Sylvestre67 deleted the syl/fix-no-fields branch January 31, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visnup visnup visnup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sylvestre67 @visnup