fix gocritic issue for internal sanitize (open-telemetry#11156)

Signed-off-by: Ziqi Zhao <[email protected]>

internal/common/sanitize/url.go

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package sanitize // import "github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/sanitize"
 
 import (
@@ -23,13 +22,13 @@ import (
 // URL removes control characters from the URL parameter. This addresses CWE-117:
 // https://cwe.mitre.org/data/definitions/117.html
 func URL(unsanitized *url.URL) string {
- escaped := strings.Replace(unsanitized.String(), "\n", "", -1)
- return strings.Replace(escaped, "\r", "", -1)
+ escaped := strings.ReplaceAll(unsanitized.String(), "\n", "")
+ return strings.ReplaceAll(escaped, "\r", "")
 }
 
 // String removes control characters from String parameter. This addresses CWE-117:
 // https://cwe.mitre.org/data/definitions/117.html
 func String(unsanitized string) string {
- escaped := strings.Replace(unsanitized, "\n", "", -1)
- return strings.Replace(escaped, "\r", "", -1)
+ escaped := strings.ReplaceAll(unsanitized, "\n", "")
+ return strings.ReplaceAll(escaped, "\r", "")
 }