chore: adds vanity import check. (open-telemetry#6305)

.github/workflows/build-and-test.yml

@@ -77,7 +77,7 @@ jobs:
  - name: Lint
  run: make -j2 golint
  - name: Checks 
- run: make -j4 checklicense misspell checkdoc impi
+ run: make -j4 checklicense misspell checkdoc impi porto
  - name: Codegem
  run: |
  make generate

Makefile

@@ -77,6 +77,10 @@ gofmt:
 golint:
  $(MAKE) for-all-target TARGET="lint"
 
+.PHONY: goporto
+goporto:
+ $(MAKE) for-all-target TARGET="porto"
+
 .PHONY: for-all
 for-all:
  @echo "running $${CMD} in root"
@@ -163,6 +167,7 @@ install-tools:
  cd $(TOOLS_MOD_DIR) && go install go.opentelemetry.io/build-tools/issuegenerator
  cd $(TOOLS_MOD_DIR) && go install golang.org/x/tools/cmd/goimports
  cd $(TOOLS_MOD_DIR) && go install go.opentelemetry.io/build-tools/multimod
+ cd $(TOOLS_MOD_DIR) && go install github.com/jcchavezs/porto/cmd/porto
 
 .PHONY: run
 run:

Makefile.Common

@@ -94,6 +94,10 @@ fmt:
 lint:
  $(LINT) run --allow-parallel-runners
 
+.PHONY: porto
+porto:
+ porto -w --include-internal --skip-dirs "^cmd$$" ./
+
 .PHONY: misspell
 misspell:
  $(MISSPELL) $(ALL_SRC_AND_DOC)

cmd/configschema/comments.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package configschema
+package configschema // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema"
 
 import (
  "go/ast"

cmd/configschema/configs.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package configschema
+package configschema // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema"
 
 import (
  "fmt"

cmd/configschema/docsgen/docsgen/cli.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package docsgen
+package docsgen // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema/docsgen/docsgen"
 
 import (
  "fmt"

cmd/configschema/docsgen/docsgen/render.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package docsgen
+package docsgen // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema/docsgen/docsgen"
 
 import (
  "bytes"

cmd/configschema/docsgen/docsgen/template.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package docsgen
+package docsgen // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema/docsgen/docsgen"
 
 import (
  "strings"

cmd/configschema/fields.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package configschema
+package configschema // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema"
 
 import (
  "fmt"

cmd/configschema/resolver.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package configschema
+package configschema // import "github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema"
 
 import (
  "fmt"

exporter/alibabacloudlogserviceexporter/config.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import "go.opentelemetry.io/collector/config"
 

exporter/alibabacloudlogserviceexporter/factory.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "context"

exporter/alibabacloudlogserviceexporter/logs_exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "context"

exporter/alibabacloudlogserviceexporter/logsdata_to_logservice.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "encoding/json"

exporter/alibabacloudlogserviceexporter/metrics_exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "context"

exporter/alibabacloudlogserviceexporter/metricsdata_to_logservice.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "sort"

exporter/alibabacloudlogserviceexporter/sanitize.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "strings"

exporter/alibabacloudlogserviceexporter/trace_exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "context"

exporter/alibabacloudlogserviceexporter/tracedata_to_logservice.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "encoding/json"

exporter/alibabacloudlogserviceexporter/uploader.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package alibabacloudlogserviceexporter
+package alibabacloudlogserviceexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/alibabacloudlogserviceexporter"
 
 import (
  "errors"

exporter/awscloudwatchlogsexporter/config.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awscloudwatchlogsexporter
+package awscloudwatchlogsexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter"
 
 import (
  "errors"

exporter/awscloudwatchlogsexporter/exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awscloudwatchlogsexporter
+package awscloudwatchlogsexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter"
 
 import (
  "context"

exporter/awscloudwatchlogsexporter/factory.go

@@ -14,7 +14,7 @@
 
 // Package awscloudwatchlogsexporter provides a logging exporter for the OpenTelemetry collector.
 // This package is subject to change and may break configuration settings and behavior.
-package awscloudwatchlogsexporter
+package awscloudwatchlogsexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter"
 
 import (
  "context"

exporter/awsemfexporter/config.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "go.opentelemetry.io/collector/config"

exporter/awsemfexporter/cwlog_client.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "fmt"

exporter/awsemfexporter/datapoint.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "time"

exporter/awsemfexporter/doc.go

@@ -14,4 +14,4 @@
 
 // Package awsemfexporter implements an OpenTelemetry Collector exporter that sends EmbeddedMetricFormat to
 // AWS CloudWatch Logs in the region the collector is running in using the PutLogEvents API.
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"

exporter/awsemfexporter/emf_exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "context"

exporter/awsemfexporter/factory.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "context"

exporter/awsemfexporter/grouped_metric.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "encoding/json"

exporter/awsemfexporter/handler/request_structuredlog_handler.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package handler
+package handler // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter/handler"
 
 import "github.com/aws/aws-sdk-go/aws/request"
 

exporter/awsemfexporter/metric_declaration.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "bytes"

exporter/awsemfexporter/metric_translator.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "encoding/json"

exporter/awsemfexporter/pusher.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "errors"

exporter/awsemfexporter/util.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awsemfexporter
+package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (
  "fmt"

exporter/awskinesisexporter/config.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awskinesisexporter
+package awskinesisexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter"
 
 import (
  "go.opentelemetry.io/collector/config"

exporter/awskinesisexporter/exporter.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awskinesisexporter
+package awskinesisexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter"
 
 import (
  "context"

exporter/awskinesisexporter/factory.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package awskinesisexporter
+package awskinesisexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter"
 
 import (
  "context"

exporter/awskinesisexporter/internal/batch/batch.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package batch
+package batch // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch"
 
 import (
  "errors"

exporter/awskinesisexporter/internal/batch/encode.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package batch
+package batch // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch"
 
 import (
  "errors"

exporter/awskinesisexporter/internal/batch/encode_jaeger.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package batch
+package batch // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch"
 
 import (
  "github.com/gogo/protobuf/proto"

exporter/awskinesisexporter/internal/batch/encode_marshaler.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package batch
+package batch // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch"
 
 import (
  "errors"

exporter/awskinesisexporter/internal/batch/encode_unsupported.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package batch
+package batch // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter/internal/batch"
 
 import "go.opentelemetry.io/collector/model/pdata"