Skip to content

Commit

Permalink
Update core to latest, fix usage of config.ComponentID (#3316)
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu committed May 4, 2021
1 parent 4cb6765 commit 7bf2266
Show file tree
Hide file tree
Showing 299 changed files with 648 additions and 759 deletions.
4 changes: 2 additions & 2 deletions cmd/otelcontribcol/components_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestDefaultComponents(t *testing.T) {
exts := factories.Extensions
for k, v := range exts {
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.CreateDefaultConfig().Type())
assert.Equal(t, config.NewID(k), v.CreateDefaultConfig().ID())
}

recvs := factories.Receivers
Expand All @@ -46,6 +46,6 @@ func TestDefaultComponents(t *testing.T) {
exps := factories.Exporters
for k, v := range exps {
assert.Equal(t, k, v.Type())
assert.Equal(t, k, v.CreateDefaultConfig().Type())
assert.Equal(t, config.NewID(k), v.CreateDefaultConfig().ID())
}
}
2 changes: 1 addition & 1 deletion exporter/alibabacloudlogserviceexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import "go.opentelemetry.io/collector/config"

// Config defines configuration for AlibabaCloud Log Service exporter.
type Config struct {
*config.ExporterSettings `mapstructure:"-"`
config.ExporterSettings `mapstructure:",squash"`
// LogService's Endpoint, https://www.alibabacloud.com/help/doc-detail/29008.htm
// for AlibabaCloud Kubernetes(or ECS), set {region-id}-intranet.log.aliyuncs.com, eg cn-hangzhou-intranet.log.aliyuncs.com;
// others set {region-id}.log.aliyuncs.com, eg cn-hangzhou.log.aliyuncs.com
Expand Down
21 changes: 8 additions & 13 deletions exporter/alibabacloudlogserviceexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,21 @@ func TestLoadConfig(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, cfg)

e0 := cfg.Exporters[typeStr]
e0 := cfg.Exporters[config.NewID(typeStr)]

// Endpoint doesn't have a default value so set it directly.
defaultCfg := factory.CreateDefaultConfig().(*Config)
defaultCfg.Endpoint = "cn-hangzhou.log.aliyuncs.com"
assert.Equal(t, defaultCfg, e0)

expectedName := typeStr + "/2"

e1 := cfg.Exporters[expectedName]
e1 := cfg.Exporters[config.NewIDWithName(typeStr, "2")]
expectedCfg := Config{
ExporterSettings: &config.ExporterSettings{
TypeVal: config.Type(typeStr),
NameVal: expectedName,
},
Endpoint: "cn-hangzhou.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
AccessKeyID: "test-id",
AccessKeySecret: "test-secret",
ExporterSettings: config.NewExporterSettings(config.NewIDWithName(typeStr, "2")),
Endpoint: "cn-hangzhou.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
AccessKeyID: "test-id",
AccessKeySecret: "test-secret",
}
assert.Equal(t, &expectedCfg, e1)

Expand Down
2 changes: 1 addition & 1 deletion exporter/alibabacloudlogserviceexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func NewFactory() component.ExporterFactory {
// CreateDefaultConfig creates the default configuration for exporter.
func createDefaultConfig() config.Exporter {
return &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
}
}

Expand Down
2 changes: 1 addition & 1 deletion exporter/alibabacloudlogserviceexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/gogo/protobuf v1.3.2
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/alibabacloudlogserviceexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -912,8 +912,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28 h1:poKw2J0C1ZE9qi85qJOOvJHHp7UJkHk80OP8IqfoFc8=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7 h1:PYYvkjl9+PSQcWc1kklY9fxhMamvzTWR1s03DZCViWQ=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
4 changes: 2 additions & 2 deletions exporter/alibabacloudlogserviceexporter/logs_exporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func createSimpleLogData(numberOfLogs int) pdata.Logs {

func TestNewLogsExporter(t *testing.T) {
got, err := newLogsExporter(zap.NewNop(), &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
Endpoint: "us-west-1.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
Expand All @@ -68,7 +68,7 @@ func TestNewLogsExporter(t *testing.T) {

func TestSTSTokenExporter(t *testing.T) {
got, err := newLogsExporter(zap.NewNop(), &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
Endpoint: "us-west-1.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (

func TestNewMetricsExporter(t *testing.T) {
got, err := newMetricsExporter(zap.NewNop(), &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
Endpoint: "us-west-1.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
func TestNewTracesExporter(t *testing.T) {

got, err := newTracesExporter(zap.NewNop(), &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
Endpoint: "cn-hangzhou.log.aliyuncs.com",
Project: "demo-project",
Logstore: "demo-logstore",
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var (

// Config defines configuration for AWS EMF exporter.
type Config struct {
*config.ExporterSettings `mapstructure:"-"`
config.ExporterSettings `mapstructure:",squash"`
// AWSSessionSettings contains the common configuration options
// for creating AWS session to communicate with backend
awsutil.AWSSessionSettings `mapstructure:",squash"`
Expand Down
24 changes: 12 additions & 12 deletions exporter/awsemfexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ func TestLoadConfig(t *testing.T) {

assert.Equal(t, 3, len(cfg.Exporters))

r0 := cfg.Exporters["awsemf"]
r0 := cfg.Exporters[config.NewID(typeStr)]
assert.Equal(t, factory.CreateDefaultConfig(), r0)

r1 := cfg.Exporters["awsemf/1"].(*Config)
r1.Validate()
r1 := cfg.Exporters[config.NewIDWithName(typeStr, "1")].(*Config)
assert.NoError(t, r1.Validate())
assert.Equal(t,
&Config{
ExporterSettings: &config.ExporterSettings{TypeVal: config.Type(typeStr), NameVal: "awsemf/1"},
ExporterSettings: config.NewExporterSettings(config.NewIDWithName(typeStr, "1")),
AWSSessionSettings: awsutil.AWSSessionSettings{
NumberOfWorkers: 8,
Endpoint: "",
Expand All @@ -71,11 +71,11 @@ func TestLoadConfig(t *testing.T) {
MetricDescriptors: []MetricDescriptor{},
}, r1)

r2 := cfg.Exporters["awsemf/resource_attr_to_label"].(*Config)
r2.Validate()
r2 := cfg.Exporters[config.NewIDWithName(typeStr, "resource_attr_to_label")].(*Config)
assert.NoError(t, r2.Validate())
assert.Equal(t, r2,
&Config{
ExporterSettings: &config.ExporterSettings{TypeVal: config.Type(typeStr), NameVal: "awsemf/resource_attr_to_label"},
ExporterSettings: config.NewExporterSettings(config.NewIDWithName(typeStr, "resource_attr_to_label")),
AWSSessionSettings: awsutil.AWSSessionSettings{
NumberOfWorkers: 8,
Endpoint: "",
Expand Down Expand Up @@ -104,8 +104,8 @@ func TestConfigValidate(t *testing.T) {
{unit: "INVALID", metricName: "404"},
{unit: "Megabytes", metricName: "memory_usage"},
}
config := &Config{
ExporterSettings: &config.ExporterSettings{TypeVal: config.Type(typeStr), NameVal: "awsemf/resource_attr_to_label"},
cfg := &Config{
ExporterSettings: config.NewExporterSettings(config.NewIDWithName(typeStr, "1")),
AWSSessionSettings: awsutil.AWSSessionSettings{
RequestTimeoutSeconds: 30,
MaxRetries: 1,
Expand All @@ -115,11 +115,11 @@ func TestConfigValidate(t *testing.T) {
MetricDescriptors: incorrectDescriptor,
logger: zap.NewNop(),
}
config.Validate()
assert.NoError(t, cfg.Validate())

assert.Equal(t, 2, len(config.MetricDescriptors))
assert.Equal(t, 2, len(cfg.MetricDescriptors))
assert.Equal(t, []MetricDescriptor{
{unit: "Count", metricName: "apiserver_total", overwrite: true},
{unit: "Megabytes", metricName: "memory_usage"},
}, config.MetricDescriptors)
}, cfg.MetricDescriptors)
}
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func NewFactory() component.ExporterFactory {
// CreateDefaultConfig creates the default configuration for exporter.
func createDefaultConfig() config.Exporter {
return &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
AWSSessionSettings: awsutil.CreateDefaultSessionConfig(),
LogGroupName: "",
LogStreamName: "",
Expand Down
4 changes: 2 additions & 2 deletions exporter/awsemfexporter/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func TestCreateTracesExporter(t *testing.T) {
require.NoError(t, err)

ctx := context.Background()
exporter, err := factory.CreateTracesExporter(ctx, component.ExporterCreateParams{Logger: logger}, cfg.Exporters["awsemf/1"])
exporter, err := factory.CreateTracesExporter(ctx, component.ExporterCreateParams{Logger: logger}, cfg.Exporters[config.NewIDWithName(typeStr, "1")])
assert.NotNil(t, err)
assert.Nil(t, exporter)
}
Expand All @@ -67,7 +67,7 @@ func TestCreateMetricsExporter(t *testing.T) {
require.NoError(t, err)

ctx := context.Background()
exporter, err := factory.CreateMetricsExporter(ctx, component.ExporterCreateParams{Logger: logger}, cfg.Exporters["awsemf/1"])
exporter, err := factory.CreateMetricsExporter(ctx, component.ExporterCreateParams{Logger: logger}, cfg.Exporters[config.NewIDWithName(typeStr, "1")])
assert.Nil(t, err)
assert.NotNil(t, exporter)
}
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/awsutil v0.0.0-00010101000000-000000000000
github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/metrics v0.0.0-00010101000000-000000000000
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7
go.uber.org/zap v1.16.0
google.golang.org/protobuf v1.26.0
)
Expand Down
4 changes: 2 additions & 2 deletions exporter/awsemfexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1034,8 +1034,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28 h1:poKw2J0C1ZE9qi85qJOOvJHHp7UJkHk80OP8IqfoFc8=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7 h1:PYYvkjl9+PSQcWc1kklY9fxhMamvzTWR1s03DZCViWQ=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.opentelemetry.io/otel v0.20.0 h1:eaP0Fqu7SXHwvjiqDq83zImeehOHX8doTvU9AwXON8g=
go.opentelemetry.io/otel v0.20.0/go.mod h1:Y3ugLH2oa81t5QO+Lty+zXf8zC9L26ax4Nzoxm/dooo=
go.opentelemetry.io/otel/metric v0.20.0/go.mod h1:598I5tYlH1vzBjn+BTuhzTCSb/9debfNp6R3s7Pr1eU=
Expand Down
2 changes: 1 addition & 1 deletion exporter/awskinesisexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type KPLConfig struct {

// Config contains the main configuration options for the awskinesis exporter
type Config struct {
*config.ExporterSettings `mapstructure:"-"`
config.ExporterSettings `mapstructure:",squash"`

AWS AWSConfig `mapstructure:"aws"`
KPL KPLConfig `mapstructure:"kpl"`
Expand Down
8 changes: 4 additions & 4 deletions exporter/awskinesisexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ func TestDefaultConfig(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, cfg)

e := cfg.Exporters["awskinesis"]
e := cfg.Exporters[config.NewID(typeStr)]

assert.Equal(t, e,
&Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
AWS: AWSConfig{
Region: "us-west-2",
},
Expand Down Expand Up @@ -76,11 +76,11 @@ func TestConfig(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, cfg)

e := cfg.Exporters["awskinesis"]
e := cfg.Exporters[config.NewID(typeStr)]

assert.Equal(t, e,
&Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
AWS: AWSConfig{
StreamName: "test-stream",
KinesisEndpoint: "awskinesis.mars-1.aws.galactic",
Expand Down
4 changes: 2 additions & 2 deletions exporter/awskinesisexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func NewFactory() component.ExporterFactory {

func createDefaultConfig() config.Exporter {
return &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
ExporterSettings: config.NewExporterSettings(config.NewID(typeStr)),
AWS: AWSConfig{
Region: "us-west-2",
},
Expand All @@ -66,7 +66,7 @@ func createTracesExporter(
) (component.TracesExporter, error) {
c := config.(*Config)
k, err := awskinesis.NewExporter(&awskinesis.Options{
Name: c.Name(),
Name: c.ID().String(),
StreamName: c.AWS.StreamName,
AWSRegion: c.AWS.Region,
AWSRole: c.AWS.Role,
Expand Down
2 changes: 1 addition & 1 deletion exporter/awskinesisexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/signalfx/opencensus-go-exporter-kinesis v0.6.3
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/awskinesisexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1084,8 +1084,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28 h1:poKw2J0C1ZE9qi85qJOOvJHHp7UJkHk80OP8IqfoFc8=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7 h1:PYYvkjl9+PSQcWc1kklY9fxhMamvzTWR1s03DZCViWQ=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
11 changes: 4 additions & 7 deletions exporter/awsprometheusremotewriteexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,19 @@ func TestLoadConfig(t *testing.T) {
require.NotNil(t, cfg)

// From the default configurations -- checks if a correct exporter is instantiated
e0 := cfg.Exporters["awsprometheusremotewrite"]
e0 := cfg.Exporters[config.NewID(typeStr)]
cfgDefault := factory.CreateDefaultConfig()
// testing function equality is not supported in Go hence these will be ignored for this test
cfgDefault.(*Config).HTTPClientSettings.CustomRoundTripper = nil
e0.(*Config).HTTPClientSettings.CustomRoundTripper = nil
assert.Equal(t, e0, cfgDefault)

// checks if the correct Config struct can be instantiated from testdata/config.yaml
e1 := cfg.Exporters["awsprometheusremotewrite/2"]
e1 := cfg.Exporters[config.NewIDWithName(typeStr, "2")]
cfgComplete := &Config{
Config: prw.Config{
ExporterSettings: &config.ExporterSettings{
NameVal: "awsprometheusremotewrite/2",
TypeVal: "awsprometheusremotewrite",
},
TimeoutSettings: exporterhelper.DefaultTimeoutSettings(),
ExporterSettings: config.NewExporterSettings(config.NewIDWithName(typeStr, "2")),
TimeoutSettings: exporterhelper.DefaultTimeoutSettings(),
RetrySettings: exporterhelper.RetrySettings{
Enabled: true,
InitialInterval: 10 * time.Second,
Expand Down
3 changes: 1 addition & 2 deletions exporter/awsprometheusremotewriteexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func (af *awsFactory) CreateDefaultConfig() config.Exporter {
},
}

cfg.TypeVal = typeStr
cfg.NameVal = typeStr
cfg.ExporterSettings = config.NewExporterSettings(config.NewID(typeStr))
cfg.HTTPClientSettings.CustomRoundTripper = func(next http.RoundTripper) (http.RoundTripper, error) {
return newSigningRoundTripper(cfg, next)
}
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsprometheusremotewriteexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/onsi/gomega v1.10.2 // indirect
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/awsprometheusremotewriteexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1054,8 +1054,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28 h1:poKw2J0C1ZE9qi85qJOOvJHHp7UJkHk80OP8IqfoFc8=
go.opentelemetry.io/collector v0.25.1-0.20210503214610-665e9657ac28/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7 h1:PYYvkjl9+PSQcWc1kklY9fxhMamvzTWR1s03DZCViWQ=
go.opentelemetry.io/collector v0.25.1-0.20210504151019-4603bad78ae7/go.mod h1:umsD61HigOQmEhlesNUobwjuEDh2lY6AvKY4SSx/fMA=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
4 changes: 2 additions & 2 deletions exporter/awsxrayexporter/awsxray.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ const (
// request and then posts the request to the configured region's X-Ray endpoint.
func newTracesExporter(
config config.Exporter, params component.ExporterCreateParams, cn awsutil.ConnAttr) (component.TracesExporter, error) {
typeLog := zap.String("type", string(config.Type()))
nameLog := zap.String("name", config.Name())
typeLog := zap.String("type", string(config.ID().Type()))
nameLog := zap.String("name", config.ID().String())
logger := params.Logger
awsConfig, session, err := awsutil.GetAWSConfigSession(logger, cn, &config.(*Config).AWSSessionSettings)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsxrayexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

// Config defines configuration for AWS X-Ray exporter.
type Config struct {
*config.ExporterSettings `mapstructure:"-"`
config.ExporterSettings `mapstructure:",squash"`
// AWSSessionSettings contains the common configuration options
// for creating AWS session to communicate with backend
awsutil.AWSSessionSettings `mapstructure:",squash"`
Expand Down
Loading

0 comments on commit 7bf2266

Please sign in to comment.