fix: fragments on interfaces in the generator #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generator contains a function `field_from_path` that accepts a root type and a path. This was originally written before I supported fragments, so assumed that the root type would always be an object (as it is for query, mutation & subscription roots). For fragments though the root type can also be an interface or a union type. This partially fixes the problem so that we support interfaces. I didn't add support for unions because unions don't specifically have fields (except `__typename`) and I can't remember how this stuff works well enough to fix it for unions right now. Suspect there might be other problems related to this in there, but that's a problem for another day. Fixes #993
✅ Deploy Preview for cynic-querygen-web canceled.
|
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator contains a function
field_from_paththat accepts a root type and a path. This was originally written before I supported fragments, so assumed that the root type would always be an object (as it is for query, mutation & subscription roots). For fragments though the root type can also be an interface or a union type.This partially fixes the problem so that we support interfaces. I didn't add support for unions because unions don't specifically have fields (except
__typename) and I can't remember how this stuff works well enough to fix it for unions right now.Suspect there might be other problems related to this in there, but that's a problem for another day.
Fixes #993