Simplify querygen output for v3 #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b81c379
to
913411b
Compare
913411b
to
d83dfbc
Compare
It doesn't support build.rs which makes it impossible to use schema registration, which the generator now requires. I think this also means we'll actually run the querygen-compile-run stuff, which I thought we were doing before but I am no longer sure of.
5ddaeb1
to
aad44b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
As part of v3 I introduced "registered schemas" - this simplifies the parameters we need to pass into derives quite a lot, and removes most of the need for
schema_for_derives.What effects does this change have?
Updates querygen with these changes in mind. I haven't exposed the ability to name a schema to the UI yet, but not sure how needed that is. Tracking that one in #690
I also started re-casing any types which weren't already being re-cased in querygen.
Fixes #671
Fixes #625