[Merged by Bors] - Fix the scalar derive. #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
✔️ Deploy Preview for cynic-querygen-web canceled. 🔨 Explore the source changes: 47f3706 🔍 Inspect the deploy log: https://app.netlify.com/sites/cynic-querygen-web/deploys/62129cee32886900073325e8 |
bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
#### Why are we making this change? #391 changed the way scalar derives worked, but it didn't handle generic types inside a scalar derive. #### What effects does this change have? Fixes generic types in a scalar derive, adds a test.
|
Canceled. |
1e48bf1
to
8ce84d3
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
#### Why are we making this change? #391 changed the way scalar derives worked, but it didn't handle generic types inside a scalar derive. #### What effects does this change have? Fixes generic types in a scalar derive, adds a test.
|
Build failed: |
8ce84d3
to
47f3706
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
#### Why are we making this change? #391 changed the way scalar derives worked, but it didn't handle generic types inside a scalar derive. #### What effects does this change have? Fixes generic types in a scalar derive, adds a test.
|
Pull request successfully merged into master. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
#391 changed the way scalar derives worked, but it didn't handle generic types inside a scalar derive.
What effects does this change have?
Fixes generic types in a scalar derive, adds a test.