Task #3132: Removing AtCompositeTest.TO_ADD_MESSAGE #3187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
replace all appearances of AtCompositeTest.TO_ADD_MESSAGE field in eo-runtime with meaningful assert messages
and don't forget to remove public modifier from this class if no longer need.
DONE:
Moved from AtCompositeTest.TO_ADD_MESSAGE to AtCompositeTest.FAILED_ASSERT_MESSAGE_SUPPLIER in tests because of more reasonable assert message.
Didn't created own FAILED_ASSERT_MESSAGE_SUPPLIER in every test class because of boilerplate.
It doesn't make any sense.
Left public modifier for AtCompositeTest because it reuses in other tests.
PR-Codex overview
This PR updates test assertions in multiple test files to use
AtCompositeTest.FAILED_ASSERT_MESSAGE_SUPPLIER.get()
instead ofAtCompositeTest.TO_ADD_MESSAGE
.Detailed summary
AtCompositeTest.TO_ADD_MESSAGE
withAtCompositeTest.FAILED_ASSERT_MESSAGE_SUPPLIER.get()
in multiple test files for improved test assertion messages.