(fix): fix minimum y scale value for vertical bar charts

oNguyenMinhHong · Mar 6, 2018 · 6f66cf0 · 6f66cf0
1 parent d8849a5
commit 6f66cf0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/bar-chart/bar-vertical.component.ts b/src/bar-chart/bar-vertical.component.ts
@@ -158,12 +158,12 @@ export class BarVerticalComponent extends BaseChartComponent {
 
   getYDomain() {
     const values = this.results.map(d => d.value);
-    
-    const min = this.yScaleMin 
+
+    const min = this.yScaleMin
       ? Math.min(this.yScaleMin, ...values)
-      : Math.min(...values);
-    
-    const max = this.yScaleMax 
+      : Math.min(0, ...values);
+
+    const max = this.yScaleMax
       ? Math.max(this.yScaleMax, ...values)
       : Math.max(...values);
 

diff --git a/src/common/shape.helper.ts b/src/common/shape.helper.ts
@@ -8,11 +8,11 @@
 export function roundedRect(x, y, w, h, r, [tl, tr, bl, br]: boolean[]) {
   let retval = '';
 
-  w = w | 0;
-  h = h | 0;
+  w = w | 1;
+  h = h | 1;
 
-  w = w < 1 ? 1 : w;
-  h = h < 1 ? 1 : h;
+  w = w === 0 ? 1 : w;
+  h = h === 0 ? 1 : h;
 
   retval = `M${[x + r, y]}`;
   retval += `h${w - 2 * r}`;