Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP show only rated button #220

Closed
wants to merge 5 commits into from
Closed

Conversation

janhoy
Copy link

@janhoy janhoy commented Sep 29, 2020

Description

A WIP for #163, still just a big hack.

TODO

  • We need to not reload the whole page when re-querying, probably using hooks?
  • Support Elastic. Currently we just send a fq to Solr to filter doc ids when show only rated is active. Need to modify splainer-search?
  • Add code to merge in the real doc position from the filtered result so scorers can take absolute position into account

Motivation and Context

See #163 for details

How Has This Been Tested?

Still just a draft

Screenshots or GIFs (if appropriate):

See #163

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@janhoy
Copy link
Author

janhoy commented Oct 7, 2020

Appreciate if someone have a look at this and give some advice :)

@epugh epugh temporarily deployed to quepid-pr-220 October 25, 2020 20:04 Inactive
@worleydl worleydl mentioned this pull request Oct 25, 2020
6 tasks
@epugh
Copy link
Member

epugh commented Nov 3, 2020

@janhoy do you mind if I close this in favor of #229 ?

@janhoy janhoy closed this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants