Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions CI #166

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Update GitHub Actions CI #166

merged 1 commit into from
Jan 14, 2024

Conversation

striezel
Copy link
Contributor

Summary

This pull requests update the actions used in GitHub Actions workflows.

The following updates are performed:

Architectural Changes

No change

New Features

No change

Improvements

Still using the outdated / unmaintained actions will generate several warnings in CI runs, for example in https://github.com/nyx-space/anise/actions/runs/7504022825:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The PR will get rid of those warnings.

Bug Fixes

No change

Testing and validation

Since this modifies the GitHub Actions workflows, passing of all jobs therein is validation.

Documentation

This PR does not primarily deal with documentation changes.

The following updates are performed:
* update actions/checkout to v4
* replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain
* replace unmaintained actions-rs/cargo by direct invocation of cargo
@ChristopherRabotin ChristopherRabotin merged commit c1129bf into nyx-space:master Jan 14, 2024
20 checks passed
@striezel striezel deleted the actions-update branch January 14, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants