Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to for more details #23

Merged
merged 1 commit into from
May 13, 2024
Merged

Update readme to for more details #23

merged 1 commit into from
May 13, 2024

Conversation

Yanglin-Tao
Copy link
Collaborator

Pull Request Template

Description

Update documentation.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Note:

Include the information the reviewers need to know.

Copy link
Collaborator

@Kylin-Mao Kylin-Mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Kylin-Mao Kylin-Mao merged commit 8b4ae40 into main May 13, 2024
1 check failed
@vchrombie
Copy link
Member

@Kylin-Mao @Yanglin-Tao

The CI fails, but the PR is approved and merged.

This is not a good practice. You need to make sure the CI is passing always. If it fails for some reason, it should be a priority to fix the CI failure unless it is for obvious reasons.

@vchrombie vchrombie mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants