Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ember-fetch to clear failing tests #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade ember-fetch to clear failing tests #190

wants to merge 1 commit into from

Conversation

Sticksword
Copy link

@Sticksword Sticksword commented Mar 29, 2021 •
edited
Loading

Problem

Opened separate PR with some new tests, noticed tests were failing on main branch already due to this error from using [email protected]

Solution

Upgrade ember-fetch by running ember install [email protected]

ember test results:

1..269
# tests 269
# pass  267
# skip  2
# fail  0

# ok

@Sticksword Sticksword force-pushed the michaelchen.upgrade-ember-fetch branch from 5e63c33 to 771c287 Compare March 29, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sticksword