Feature/identity verification #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
force-pushed
the
feature/identity-verification
branch
from
8cc5d8d
to
718b662
Compare
jstuczyn
requested review from
aniampio,
durch,
futurechimp and
neacsu
as code owners
durch
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a signature verification on mixnode/gateway bonding.
I've introduced extra field to the wallet, but it doesn't perform any "proper" validation, so perhaps after I'm done with my changes, somebody from @nymtech/product team could take a look to deal with the TypeScript side of things?
The work remaining: