Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use ts-rs in tests #894

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Only use ts-rs in tests #894

merged 1 commit into from
Nov 11, 2021

Conversation

durch
Copy link
Contributor

@durch durch commented Nov 10, 2021

Closes #893

@durch durch added the wallet label Nov 10, 2021
@durch durch self-assigned this Nov 10, 2021
@mmsinclair
Copy link
Contributor

@tommyv1987 any idea why these are failing now?

https://github.com/nymtech/nym/runs/4166123701?check_suite_focus=true

image

@mmsinclair mmsinclair merged commit 41b77c3 into develop Nov 11, 2021
@mmsinclair mmsinclair deleted the feature-gate-ts-rs branch November 11, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsinclair mmsinclair mmsinclair approved these changes

@futurechimp futurechimp Awaiting requested review from futurechimp

@jstuczyn jstuczyn Awaiting requested review from jstuczyn

@neacsu neacsu Awaiting requested review from neacsu

Assignees

@durch durch

Labels
wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature gate ts-rs everywhere and only build use it to export types during CI runs
2 participants
@durch @mmsinclair