Feature/nymd client integration #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neacsu
reviewed
Aug 18, 2021
Comment on lines
+63
to
+64
| // this behaviour should definitely be changed, we shouldn't | ||
| // need to get bandwidth credential for registration |
There was a problem hiding this comment.
Why not? When do you think we should get it? What I had in mind was that we get it at registration/authentication and consume it during that session.
There was a problem hiding this comment.
My understanding is that bandwidth credential, as its name suggests, is used to access the mix network. However, during registration we are not sending any traffic through the network. Perhaps we should discuss this more with somebody else, maybe @aniampio ?
durch
approved these changes
Aug 18, 2021
neacsu
approved these changes
Aug 18, 2021
|
Feel free to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates the new validator client into the code base - mixnodes, gateways, clients and validator api are now using it.
The final remaining thing, which will be done in another pull request, is to make actual payments happen.
I'm sorry for whoever reviews it, but after the BIG MERGE ™️ this PR got rather bloated : (