Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed overflow in determining reconnection backoff #1260

Merged
merged 3 commits into from
May 9, 2022

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented May 9, 2022

Description

Closes: #1123

Even though we were performing checked_mul to ensure we couldn't overflow by attempting to determine backoff for reconnecting to a dead mixnode, we didn't do the exponentiation. This PR fixes it.

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn changed the title Fixed overflow in determining connection backoff Fixed overflow in determining reconnection backoff May 9, 2022
@jstuczyn jstuczyn merged commit 0f6f47c into develop May 9, 2022
@jstuczyn jstuczyn deleted the bugfix/mixnet-client-backoff-overflow branch May 9, 2022 12:23
@jstuczyn jstuczyn added this to In progress in Core systems via automation May 10, 2022
@jstuczyn jstuczyn moved this from In progress to QA in Core systems May 10, 2022
@tommyv1987 tommyv1987 moved this from QA to Docs in Core systems May 30, 2022
@tommyv1987 tommyv1987 moved this from Docs to Done in Core systems May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Core systems
  
Done
Development

Successfully merging this pull request may close these issues.

mixnode hard restart after tokio-runtime-worker panicked
1 participant