Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Netlify Deploy URL #217

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

nwtgck
Copy link
Owner

@nwtgck nwtgck commented Feb 4, 2020

I'll use force push to confirm.

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch from f6214b9 to ad71294 Compare February 4, 2020 11:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

👋 Thanks for reporting!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

👋 Thanks for reporting!

@peaceiris
Copy link

peaceiris commented Feb 4, 2020

We can parse the Json file using jq and pass a URL to github-script action as outputs.

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch from ad71294 to cce497f Compare February 4, 2020 11:28
@nwtgck
Copy link
Owner Author

nwtgck commented Feb 4, 2020

@peaceiris Thanks! I'll use require('fs'). Cannotfs access to the local file?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

{
"site_id": "7c9ee3e6-ade3-4032-bac0-3a3ed25ae3e6",
"site_name": "piping-ui",
"deploy_id": "5e3955978a7d417318d51c53",
"deploy_url": "https://5e3955978a7d417318d51c53--piping-ui.netlify.com",
"logs": "https://app.netlify.com/sites/piping-ui/deploys/5e3955978a7d417318d51c53"
}

@nwtgck
Copy link
Owner Author

nwtgck commented Feb 4, 2020

fs can be used!

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch from cce497f to ba21fa3 Compare February 4, 2020 11:32
@peaceiris
Copy link

peaceiris commented Feb 4, 2020

- name: Set URL
  id: deploy_url
  run: |
    export URL=$(cat ./json.json | jq -r '.deploy_url')
    echo "::set-output name=deploy_url::${URL}"

- uses: actions/[email protected]
  with:
    github-token: ${{secrets.GITHUB_TOKEN}}
    script: |
     ...
      body: ${{ steps.deploy_url.outputs.deploy_url }}

@nwtgck
Copy link
Owner Author

nwtgck commented Feb 4, 2020

@peaceiris Great! But, I'd like to avoid to use environment variables as possible.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@peaceiris
Copy link

Good!

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch 3 times, most recently from 5be1928 to ee38515 Compare February 4, 2020 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch 2 times, most recently from cd7771d to d1dcfaa Compare February 4, 2020 11:44
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch from d1dcfaa to abe6455 Compare February 4, 2020 11:45
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@nwtgck nwtgck force-pushed the feature/netlify-deploy-url-comment branch from abe6455 to 1aa2044 Compare February 4, 2020 11:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2020

@nwtgck nwtgck merged commit 0c6bcc2 into develop Feb 4, 2020
@nwtgck nwtgck deleted the feature/netlify-deploy-url-comment branch February 4, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants