Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frameless windows have a lot of issues on Linux and Windows (With NW2 mode) #8153

Closed
2 of 3 tasks
malisipi opened this issue Dec 27, 2023 · 19 comments
Closed
2 of 3 tasks
Assignees
Labels
bug has-min-repro Has a minimum reproduction regression

Comments

@malisipi
Copy link

malisipi commented Dec 27, 2023

Issue Type

Before opening an issue, please search and see if it has already been raised.

  • Bug Report

  • Feature Request

  • Successfully reproduced against the latest version of NW.js?

Please use our mailing list or Gitter chatroom to ask questions. The issue tracker is only for bugs and feature requests, in English only. Please note that issues without a repro or code snippet are less likely to be resolved.

Current/Missing Behavior

  • The last update was broke (from 0.82.0 to 0.83.0) -webkit-app-region:drag CSS feature. (in Wayland, X11)
  • Also in X11, frameless examples is working with a titlebar. (Also related with The recent versions have been a bunch of disasters! #8137)
    Ekran Görüntüsü - 2023-12-27 22-04-00
  • Transparency also is not working correctly with latest version. (in Wayland, X11)

Expected/Proposed Behavior

  • All frameless examples works without titlebar
  • NW will respect -webkit-app-region property.
  • Also transparency is working correctly.

Additional Info

Those bugs is fixed when disabled NW2 mode. (--disable-features=nw2) #7230

@ssnangua
Copy link

ssnangua commented Jan 1, 2024

Win10 the same issues.

@UtterDonkey
Copy link

UtterDonkey commented Jan 13, 2024

Same issue in windows 11.

@UtterDonkey
Copy link

@rogerwang Could you take a look at this please?

@UtterDonkey
Copy link

Might I suggest you rename this issue so that it's more obvious it's an issue with frameless windows themselves and not with the frameless examples?

@malisipi malisipi changed the title Frameless examples causes with issues (Linux X11 and Wayland) Frameless windows have a lot of issues on Linux and Windows (With NW2 mode) Jan 20, 2024
@UtterDonkey
Copy link

I'm not able to reproduce this problem in v0.82.0.

@UtterDonkey
Copy link

UtterDonkey commented Jan 25, 2024

@rogerwang
Copy link
Member

The drag issue will be fixed and released in upcoming 0.85.0 with Chromium 122. Thanks.

@jonlepage
Copy link
Contributor

The drag issue will be fixed and released in upcoming 0.85.0 with Chromium 122. Thanks.

hi roger, is this fix app-region: drag ?
https://discord.com/channels/806232493770276865/806232494445690892/1207021495860334662
thank for clarification.

@rogerwang
Copy link
Member

I was testing my local fix with OP's sample, which uses -webkit-app-region: drag.

@UtterDonkey
Copy link

Have you managed to fix any other of the issues with frameless windows like transparency, rounded corners etc.?

@UtterDonkey
Copy link

UtterDonkey commented Feb 18, 2024

I will test it for my issues on windows as soon as possible and get back to you.

@UtterDonkey
Copy link

@rogerwang

I get this weird effect after moving a window with resizable: false and then if I make it frameless, it removes the rounded corners.

Untitled.154.mp4

@Sheepux
Copy link

Sheepux commented Feb 25, 2024

Fixed the issue for me as well (windows)

@UtterDonkey
Copy link

UtterDonkey commented Feb 26, 2024

@rogerwang

I get this weird effect on the borders after moving a window with resizable: false and then if I make it frameless, it removes the rounded corners.

Untitled.154.mp4

@Sheepux Are you able to reproduce any of these problems?

@malisipi
Copy link
Author

malisipi commented Feb 26, 2024

Please try this build: https://dl.nwjs.io/live-build/nw85/20240217-223403/1c035e527/v0.85.0/nwjs-sdk-v0.85.0-linux-x64.tar.gz https://dl.nwjs.io/live-build/nw85/20240217-163921/0782fe73e/v0.85.0/nwjs-sdk-v0.85.0-win-x64.zip

-webkit-drag-region CSS property and titlebar issues is fixed on Ubuntu 23.10 x86_64.

However there're still some problems about transparency. It would be a sync issue about Gnome' window manager. (Also it can be reproducible in XWayland and Wayland).

Also still context menu of draggable area is still showing "(empty)" text instead of opening system menu (like Windows does).

Issue Expected Behaviour
Image1 Image2

@jonlepage
Copy link
Contributor

@rogerwang
this one worked
#8153 (comment)
but update to 0.88.0 will broke app-region again !

@rogerwang
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug has-min-repro Has a minimum reproduction regression
Projects
None yet
Development

No branches or pull requests

7 participants