Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win/Linux, nw 0.13+] Menu still is visible in fullscreen and cannot be removed once set #4725

Closed
sebadorn opened this issue Apr 14, 2016 · 1 comment
Assignees
Milestone

Comments

@sebadorn
Copy link

Windows 7, Windows 10 (both 32bit in a VM) and Linux (Ubuntu 14.04) with NW.js v0.13.4:

The window menu set with nw.Window.get().menu = myMenu; is still visible when in fullscreen mode or kiosk mode. As a workaround I tried to temporarily remove the menu when entering fullscreen mode, but nw.Window.get().menu = null; didn't change anything.
It's possible to set an empty menu with nw.Window.get().menu = new nw.Menu({type: 'menubar'}), but that still leaves the – now empty – menu bar.


Only tested on Windows 10 with NW.js v0.14.0:

Clicking a menu item which has a submenu doesn't open the submenu. Nothing happens. Also still visible in fullscreen/kiosk mode.

@rogerwang rogerwang added this to the 0.14.x milestone Apr 15, 2016
@ghostoy
Copy link
Member

ghostoy commented Apr 18, 2016

@rogerwang @sebadorn On 0.12.x, the menubar shows in fullscreen on Linux, but doesn't show it on Windows. However neither shown or hidden is defined in the doc or wiki. Some one may need the menubar on full screen mode, and some one may not. So I think it's better to leave the choices, whether to show or hide menubars in full screen mode, to the developers.

Anyway, when set win.menu = null, the menubar should disappear on all platforms. I'll try to fix this issue and update the usage of setting win.menu = null on the doc site.

ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Apr 19, 2016
Previously in 0.12.x the visibility of menubar on fullscreen/kiosk
 mode is inconsistent on different platforms. Since 0.13.0, the
menubar is always visible on fullscreen / kiok mode. Using
`win.menu=null` can remove the menubar manually. This gives
developers better control on the menubars.

This patch implemented `win.menu=null` to completely remove the
menubar on Linux and Windows, and cleared out the menubar on Mac.
The patch also updated the docs about menubar visibility on
fullscreen mode.

Fixed nwjs#4725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants