Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need MP3 and MP4 in 0.13.0 #4492

Closed
ghost opened this issue Mar 4, 2016 · 18 comments
Closed

Need MP3 and MP4 in 0.13.0 #4492

ghost opened this issue Mar 4, 2016 · 18 comments

Comments

@ghost
Copy link

ghost commented Mar 4, 2016

As a web developer its too cumbersome to try learn how to add Proprietary Codecs. I use to get ffmpegsumo.dll from chrome installation but they no longer seem to be there.

I have and always used mp3 and mp4, so support is a must for me.

Might have to either stay with 0.12 or move to electron.

Which is sad cause I like the NWjs environment better and its more upto date. Electron is still on chrome 47

@rogerwang
Copy link
Member

In recent versions of Chromium project, ffmpeg DLL was changed to be builtin. And we don't have license to redistribute the codec in question. So developers don't have any ways to get the codec without compiling.

To make things easier, we'll build ffmpegsumo as a separate DLL in the next RC version. The DLL we distribute will not contain any codec in question. Developers can recompile the DLL for themselves, which is much easier than compiling NW. Or they can get DLL from someone else from the community.

Note that developers can redistribute binaries containing these codecs as long as they have the license. If a developer doesn't have the license, moving to Electron doesn't make him/her eligible to redistribute the codecs.

rogerwang added a commit that referenced this issue Mar 4, 2016
@AndryBray
Copy link

@rogerwang will you write some doc about how to build the DLL? Is this procedure the same for Mac & Linux? Thank you

@AndryBray
Copy link

@rogerwang I'm trying to build the ffmpeg but without success.
I don't know how to go on... the doc about that is really poor.

Why don't you build it for who can use this feature?

I mean it's the same like I will go to pay someone to build it for me... he/she doesn't need to be eligible to use MP3 codec/license because at the end he/she is not going to use it for personal/commercial purpose.

@barticus22
Copy link

@AndryBray I can build a custom nwjs that meets your requirements. Please let me know if you are interested.

@AndryBray
Copy link

thank you @barticus22
but how will be with the next version? nwjs will go to change very fast and I'd like to be updated with latest versions, even nightly build.

The best would be to find this build inside the repository as a normal build, @rogerwang do you agree?

@fuwenchun
Copy link

@barticus22 I need the ffmpeg.dll of 32bit,support mp3,can you help me to build it.

@rogerwang
Copy link
Member

Theoretically the ffmpeg dll doesn't need to be rebuilt for minor version update.

Per your previous question @AndryBray , I can't redistribute the binary because I don't have the license, as I stated repeatedly. And there is obvious difference between redistributing the dll and delivery to only you from someone doing it on your behalf.

@rogerwang
Copy link
Member

The documentation for enabling the codecs in question is in https://docs.nwjs.io/en/latest/For%20Developers/Enable%20Proprietary%20Codecs/ . Anyone who need help following the doc should follow #4595

@davidsonbpe
Copy link

cara eu to pressionando muito DLL ffmpeg mp3 e mp4 na v0.13.3

@guogaigai
Copy link

@barticus22 I also need the ffmpeg.dll of 32bit to support mp4 , can you help me to build it

@guogaigai
Copy link

@rogerwang I can not compile the ffmpeg successful for cannot visit google site when compiling . If possible ,can you help me to build ffmpeg.dll for win32 , thank you ~

@iteufel
Copy link
Contributor

iteufel commented Apr 19, 2016

@guogaigai You can download prebuilt binaries from https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases

@guogaigai
Copy link

@iteufel thank you very much ~

@vzamanillo
Copy link

Seems like building a custom ffmpeg with proprietary codecs support is not enought to get the it working, correct me if I am wrong or confused but the NW.js prebuilt needs a build with the interface to proprietary codecs (proprietary_codecs=true argument), I was testing the nwjs-v0.17.5 prebuilt with a custom ffmpeg library builded with proprietary codecs to get ac3 audio and did not work.

@rogerwang
Copy link
Member

@vzamanillo interface to proprietary codecs is already enabled in official binary.

@vzamanillo
Copy link

@rogerwang Thank you, then I assume that a custom build of ffmpeg with extra codecs should work, or it is neccesary to do something else?.

@cecilpeng
Copy link

@iteufel Thanks very much for your contribution. It works well. https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases

@cleversonsf
Copy link

cleversonsf commented Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants