Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libssl-dev to Docker image #1835

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Jun 13, 2018

No description provided.

@ljharb
Copy link
Member

ljharb commented Jun 13, 2018

Why?

@sturman
Copy link
Contributor Author

sturman commented Jun 13, 2018

because installation of Node.js v0.6.20 in Docker failed due to missing OpenSSL. Unfortunately, I don't have log now

@ljharb
Copy link
Member

ljharb commented Jun 13, 2018

cc @PeterDaveHello

@sturman
Copy link
Contributor Author

sturman commented Jun 14, 2018

Log

nvm@9ef00ffa3b8f:~/.nvm$ nvm install 0.6.20
Detected that you have 8 CPU core(s)
Running with 7 threads to speed up the build
Downloading https://nodejs.org/dist/v0.6.20/node-v0.6.20.tar.gz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums matched!
$>./configure --prefix=/home/nvm/.nvm/v0.6.20 <
Checking for program g++ or c++          : /usr/bin/g++ 
Checking for program cpp                 : /usr/bin/cpp 
Checking for program ar                  : /usr/bin/ar 
Checking for program ranlib              : /usr/bin/ranlib 
Checking for g++                         : ok  
Checking for program gcc or cc           : /usr/bin/gcc 
Checking for gcc                         : ok  
Checking for library dl                  : not found 
Checking for openssl                     : not found 
Checking for function SSL_library_init   : not found 
Checking for header openssl/crypto.h     : not found 
/home/nvm/.nvm/.cache/src/node-v0.6.20/files/wscript:386: error: Could not autodetect OpenSSL support. Make sure OpenSSL development packages are installed. Use configure --without-ssl to disable this message.
nvm: install v0.6.20 failed!
nvm@9ef00ffa3b8f:~/.nvm$ 

Dockerfile Outdated
@@ -56,7 +56,8 @@ RUN apt update && \
g++-4.8 \
xz-utils \
build-essential \
bash-completion && \
bash-completion \
libssl-dev && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to move this package upper so that we can focus and minimize the change/diff.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it’s ok with @PeterDaveHello

Copy link
Collaborator

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@PeterDaveHello
Copy link
Collaborator

The commits should be squashed into a single one.

@sturman sturman force-pushed the add_libssl_to_docker_image branch from abbc8a0 to 29d43e4 Compare June 18, 2018 07:33
@sturman
Copy link
Contributor Author

sturman commented Jun 19, 2018

@PeterDaveHello commits are squashed into single one

@ljharb ljharb force-pushed the add_libssl_to_docker_image branch 2 times, most recently from 20b9645 to 7b0a46e Compare September 28, 2019 02:21
@ljharb ljharb merged commit 7b0a46e into nvm-sh:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants