Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nvm cache clear message less ambiguous #1644

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Make nvm cache clear message less ambiguous #1644

merged 1 commit into from
Oct 29, 2017

Conversation

citrusui
Copy link
Contributor

I have a Bash function that I use to clear out my apt and nvm caches.

screenshot from 2017-10-28 20 31 28


If you weren't aware nvm was on your system, the last line (above) is likely to cause some confusion. Here's a simple fix:

screenshot from 2017-10-28 20 37 46

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your scenario, i'd add disambiguating echos to your cch function, since typically everyone seeing this message just typed "nvm cache clear".

That said, these changes seem good.

@ljharb ljharb merged commit 9953a52 into nvm-sh:master Oct 29, 2017
ljharb added a commit to ljharb/nvm that referenced this pull request Dec 9, 2017
Fixes
 - fix unassigned variable (nvm-sh#1665, nvm-sh#1664)
 - Fix for $path used by zsh (nvm-sh#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (nvm-sh#1644)
 - Added missing piece (nvm-sh#1658)
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
[Docs] Make `nvm cache clear` message less ambiguous
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
Fixes
 - fix unassigned variable (nvm-sh#1665, nvm-sh#1664)
 - Fix for $path used by zsh (nvm-sh#1669)
 - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671)
 - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676)
 - `nvm install-latest-npm`: fix node 4-4.6

Documentation
 - Make `nvm cache clear` message less ambiguous (nvm-sh#1644)
 - Added missing piece (nvm-sh#1658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants